re: Remove usage of serde from near-network-primitives
#5546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmnoxx
requested review from
bowenwang1996,
chefsale,
khorolets,
miraclx and
mm-near
as code owners
Open
4 tasks
miraclx
approved these changes
Nov 30, 2021
chefsale
approved these changes
Dec 1, 2021
bowenwang1996
approved these changes
Dec 1, 2021
pmnoxx
added
A-network
mm-near
approved these changes
Dec 10, 2021
pmnoxx
force-pushed
the
piotr-remove-serde-from-near-network-primitives
branch
from
aa9861f to
ec674f8
Compare
near-bulldozer
bot
deleted the
piotr-remove-serde-from-near-network-primitives
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are planning to separate
jsonrpctypes from rest of the code base. We can start by separating types fromnear-network-primitivesfromjsonrpcby removing direct usage ofserdefrom that crate.See #5516
TODO: (next PR)