Base function call computations #4529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matklad
reviewed
Jul 16, 2021
| fn test_function_call(metric: GasMetric, vm_kind: VMKind) { | ||
| let mut xs = vec![]; | ||
| let mut ys = vec![]; | ||
| const REPEATS: i32 = 50; |
There was a problem hiding this comment.
Suggested change
| const REPEATS: i32 = 50; | |
| const REPEATS: u64 = 50; |
Comment on lines
74
to
81
| " | ||
| (export \"hello{}\" (func {})) | ||
| (func (;{};) | ||
| i32.const {} | ||
| drop | ||
| return | ||
| ) | ||
| ", i, i, i, i) |
There was a problem hiding this comment.
Suggested change
| " | |
| (export \"hello{}\" (func {})) | |
| (func (;{};) | |
| i32.const {} | |
| drop | |
| return | |
| ) | |
| ", i, i, i, i) | |
| r#" | |
| (export "hello{i}" (func {i})) | |
| (func (;{i};) | |
| i32.const {i} | |
| drop | |
| return | |
| ) | |
| "#, i=i) |
although I guess it's better to use some wat sugar here to not repeat the i in the first place:
write!(
&mut methods,
r#"
(func (export "hello{i}")
i32.const {i}
drop
return
)
"#,
i = i
)| )", | ||
| methods | ||
| ); | ||
| ContractCode::new(wabt::wat2wasm(code.as_bytes()).unwrap(), None) |
There was a problem hiding this comment.
needs a rebase, we now use wat instead of wabt.
| #[test] | ||
| fn test_function_call_time() { | ||
| // Run with | ||
| // cargo test --release --lib function_call::test_function_call_time -- --exact --nocapture |
There was a problem hiding this comment.
Hm, shouldn't this include --features required as well?
I think as written, this'll hit the in-memory cache, masking the deserializaion costs, and desiralization should be the primary contributor to func call cost
There was a problem hiding this comment.
Done, although from results it doesn't seem so.
Longarithm
reviewed
Jul 16, 2021
| test_function_call(GasMetric::ICount, VMKind::Wasmtime); | ||
| } | ||
|
|
||
| fn make_many_methods_contact(method_count: i32) -> ContractCode { |
There was a problem hiding this comment.
Suggested change
| fn make_many_methods_contact(method_count: i32) -> ContractCode { | |
| fn make_many_methods_contract(method_count: i32) -> ContractCode { |
| let mut ys = vec![]; | ||
| const REPEATS: i32 = 50; | ||
| for method_count in vec![5, 20, 30, 50, 100, 200, 1000] { | ||
| let contract = make_many_methods_contact(method_count); |
There was a problem hiding this comment.
Nit
Suggested change
| let contract = make_many_methods_contact(method_count); | |
| let contract = make_many_methods_contract(method_count); |
matklad
approved these changes
Jul 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.