Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update example contract #3929

Merged
merged 2 commits into from
Mar 24, 2021
Merged

Conversation

matklad
Copy link
Contributor

@matklad matklad commented Feb 8, 2021

No description provided.

@matklad
Copy link
Contributor Author

matklad commented Feb 8, 2021

Ideally, I would like to add an integration test to near-vm-runner-standalone which runs cargo build example-contract, to make sure this doesn't regress in the future. I am not sure that would be a good idea. I have a couple of questions regarding to that:

  • can we stomach CI time increase by CPU minute? Compiling even the empty contract takes a lot of time, as it uses full syn, and near_sdk is pretty heavy.
  • what is the compatibility story between near-sdk and nearcore? The contract has to depend on a published version of nearsdk. Can it be the case that the published version of nearsdk becomes incompatible with the master of nearcore?

@willemneal
Copy link
Contributor

I think it would be a good idea to not depend an the sdk to compile the contract. @evgenykuzyakov had a recent example, but I can't find it.

@matklad
Copy link
Contributor Author

matklad commented Feb 11, 2021

Yeah, actually, I've found a bunch of better maintained contracts in this repository. I think we can remove this example instead of upgrading it to the modern sdk version?

@matklad matklad requested a review from olonho as a code owner March 24, 2021 10:06
@near-bulldozer near-bulldozer bot merged commit 9dcc926 into near:master Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants