feat(upgradability): Reintroducing handshake #3290
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfornet
requested review from
evgenykuzyakov,
frol and
MaksymZavershynskyi
as code owners
|
|
bowenwang1996
approved these changes
Sep 4, 2020
| height: peer_chain_info.height, | ||
| tracked_shards: peer_chain_info.tracked_shards, | ||
| // TODO(MOO): Select default value for archival node | ||
| archival: false, |
There was a problem hiding this comment.
default should be false. I don't think we need to change it
mfornet
force-pushed
the
upgrade_step_3
branch
2 times, most recently
from
cb5e084 to
d7efa24
Compare
mfornet
force-pushed
the
upgrade_step_3
branch
from
d7efa24 to
a0cdfe1
Compare
|
Note: backward_compatible and upgradable tests won't pass until |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the 3rd step (version 36) as proposed in #3289.
Note: Merge after 2nd step is deployed (#3157)
Test plan
pytest/tests/sanity/upgradable.py and tests/sanity/backward_compatible.py should pass using as stable branch #3157
nayduck run: http://nayduck.eastus.cloudapp.azure.com:3000/#/run/318