Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(nightly): Measure blocks per second using near_blocks_per_minute metric #2988

Merged
merged 2 commits into from
Jul 14, 2020
Merged

fix(nightly): Measure blocks per second using near_blocks_per_minute metric #2988

merged 2 commits into from
Jul 14, 2020

Conversation

birchmd
Copy link
Contributor

@birchmd birchmd commented Jul 14, 2020

Originally bps was computed by taking two near_block_processed measurements and dividing the difference by the elapsed time. This gave an unreliable result, so we now instead use the metric which exposes the block rate directly.

@gitpod-io
Copy link

gitpod-io bot commented Jul 14, 2020 •
edited
Loading

@nearprotocol-bulldozer nearprotocol-bulldozer bot merged commit 474e408 into near:master Jul 14, 2020
@birchmd birchmd deleted the fix-mocknet-bps branch July 14, 2020 22:07
@weekly-digest weekly-digest bot mentioned this pull request Jul 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SkidanovAlex SkidanovAlex SkidanovAlex approved these changes

@ilblackdragon ilblackdragon Awaiting requested review from ilblackdragon

@bowenwang1996 bowenwang1996 Awaiting requested review from bowenwang1996

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@birchmd @SkidanovAlex