Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(nightly): avoid epoch boundaries in state sync tests #2982

Merged
merged 2 commits into from
Jul 13, 2020
Merged

fix(nightly): avoid epoch boundaries in state sync tests #2982

merged 2 commits into from
Jul 13, 2020

Conversation

Kouprin
Copy link
Member

@Kouprin Kouprin commented Jul 11, 2020 •
edited
Loading

Fixes #2981.

Running Store Validation takes only 400 ms which cannot be cause of timeout. The issue was in running get_all_heights at the same time while Epoch is switching.

TEST PLAN

State Sync tests pass in custom Nightly.

Screen Shot 2020-07-11 at 1 13 37 PM

@gitpod-io
Copy link

gitpod-io bot commented Jul 11, 2020 •
edited
Loading

@Kouprin Kouprin marked this pull request as ready for review July 11, 2020 10:16
@Kouprin Kouprin requested review from SkidanovAlex and bowenwang1996 and removed request for SkidanovAlex July 11, 2020 10:17
bowenwang1996
bowenwang1996 reviewed Jul 11, 2020
View reviewed changes
Copy link
Collaborator

@bowenwang1996 bowenwang1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue was in running get_all_heights at the same time while Epoch is switching.

Why is it bad?

@Kouprin
Copy link
Member Author

Kouprin commented Jul 11, 2020

The issue was in running get_all_heights at the same time while Epoch is switching.

Why is it bad?

It seems we're super strict to get the response in 2 seconds. On the Epoch boundary some State Sync related expensive things appear that leads to timeout.

@nearprotocol-bulldozer nearprotocol-bulldozer bot merged commit b1f0f03 into master Jul 13, 2020
@nearprotocol-bulldozer nearprotocol-bulldozer bot deleted the state_sync_tests branch July 13, 2020 17:16
@weekly-digest weekly-digest bot mentioned this pull request Jul 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bowenwang1996 bowenwang1996 bowenwang1996 approved these changes

@SkidanovAlex SkidanovAlex Awaiting requested review from SkidanovAlex

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

state_sync.py triggers read timeout during getting blocks while epoch is switching
2 participants
@Kouprin @bowenwang1996