feat(Chain): move check_refcount_map into Store Validator + caching Tx Refcounts while GCing #2937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Kouprin
force-pushed
the
refcount_map
branch
5 times, most recently
from
b0d8921 to
6b8cd8e
Compare
Kouprin
changed the title
Kouprin
force-pushed
the
refcount_map
branch
2 times, most recently
from
12a8789 to
478da5c
Compare
Kouprin
requested review from
bowenwang1996,
evgenykuzyakov,
frol and
SkidanovAlex
as code owners
bowenwang1996
approved these changes
Jul 4, 2020
* feat(Store Validator): State Header validation for State Parts * state_header_block_exists * get_num_state_parts
frol
approved these changes
Jul 6, 2020
Comment on lines
+2405
to
+2407
| let mut refcount = self.chain_store.get_tx_refcount(&tx.get_hash())?; | ||
| refcount += 1; | ||
| store_update.set_ser(ColTransactionRefCount, tx.get_hash().as_ref(), &refcount)?; |
There was a problem hiding this comment.
Do we ensure that this does not lead us to a race condition?
There was a problem hiding this comment.
We cannot increase and decrease Tx Refcount in one store update operation. While increasing, we cannot add same Tx twice. There is also a comment in finalize() method explaining this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sanity/epoch_switches.pyTEST PLAN
CI + custom Nightly