Version bump of 1.2.0

[chefsale]

This is using the automatic toml update of the version and it unwrapped the dependencies as well. In the future only versions should be updated.

[bowenwang1996]

why not fix the automated tool?

[chefsale]

why not fix the automated tool?

The automated tool is actually doing the right thing:

This is the code:

        cargo_toml = toml.loads(base64.b64decode(cargo.content).decode("utf-8"))
        previous_version = cargo_toml['package']['version']
        if cargo_toml['package']['version'] == version:
            logging.info("Versions are the same. Skipping bumping")
            return

        cargo_toml['package']['version'] = version
        response = self.repo.update_file(
            "neard/Cargo.toml",
            f"Automatic version bump from {previous_version} to {version}",
            toml.dumps(cargo_toml), cargo.sha, branch_name

dumps just spits out a string which is minimized, couldn't find a way to specify not to do that. we could create some custom parser, but this way I thought we would be more consistent and precise.

[frol]

Can the tool keep the existing formatting of the file and only touch the relevant piece? (I know it might be challenging, but still worth asking as it is common to have package section on the top while it seems that it rewrote the whole file to its liking.)

As a hack, I can suggest we use simple regex replacement with toml parsing before and after to ensure that we changed the right line (parse the original version, modify the version, apply the change to the toml file using regex replacement [do NOT dump the parsed toml], parse the new version again and compare the result with the originally patched version of the toml, they should be equal)

[chefsale]

Yep, will do that.

[gitpod-io]

[chefsale]

@frol @bowenwang1996 Here you go, its a dirty hack, but it works:
https://github.com/nearprotocol/near-ops/pull/74/commits/ba047d3377915a322a256f06d51ab535db047fc3

I tried with regexes first, but this seemed like a better simple way of not messing up.

[frol]

Much cleaner now 😄