Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(congestion_control) - relax congestion control - part 2 #12430

Merged
merged 6 commits into from
Nov 11, 2024
Merged

Conversation

wacban
Copy link
Contributor

@wacban wacban commented Nov 11, 2024

relaxing the congestion control to allow more gas (receipts) in the delayed receipts queue.

Please note I'm adding it directly to protocol version 73 because it wasn't released yet. @staffik Will it be possible to get it into 2.4?

@wacban wacban requested a review from a team as a code owner November 11, 2024 13:01
@staffik
Copy link
Contributor

staffik commented Nov 11, 2024

@staffik Will it be possible to get it into 2.4?

I plan to cut the branch tomorrow my morning, so that this change would still get in if it is merged today.

Copy link
Contributor

@staffik staffik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to unblock. Seen the zulip thread that 400Pgas is fine.
But I do not fully get what are implications of that so it would be best if someone that understand it approve this PR too.

Sanity check, is max_congestion_incoming_gas: 9_223_372_036_854_775_807 in
core/parameters/res/runtime_configs/parameters.yaml
an original value that was changed in later protocol versions, and we do not have to change it in this file?

@@ -208,7 +208,7 @@ vm_kind NearVm
eth_implicit_accounts true
yield_resume true
discard_custom_sections true
max_congestion_incoming_gas 40_000_000_000_000_000
max_congestion_incoming_gas 400_000_000_000_000_000
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we edit this file? There is a note in 3rd line that we should not edit it 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is autogenerated and I did indeed generate it. For more context please see

The latest values of parameters can be found in `parameters.snap`. This file is
automatically generated by tests and needs to be reviewed and committed whenever
any of the parameters changes.

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 7.69231% with 12 lines in your changes missing coverage. Please review.

Project coverage is 71.68%. Comparing base (a03f42c) to head (3eff6e5).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
core/parameters/src/config_store.rs 7.69% 12 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #12430       +/-   ##
===========================================
+ Coverage   39.74%   71.68%   +31.93%     
===========================================
  Files         842      843        +1     
  Lines      170756   170778       +22     
  Branches   170756   170778       +22     
===========================================
+ Hits        67872   122425    +54553     
+ Misses      98642    42985    -55657     
- Partials     4242     5368     +1126     
Flag Coverage Δ
backward-compatibility 0.16% <0.00%> (-0.01%) ⬇️
db-migration 0.16% <0.00%> (-0.01%) ⬇️
genesis-check 1.27% <0.00%> (-0.01%) ⬇️
integration-tests 39.35% <7.69%> (-0.01%) ⬇️
linux 70.98% <7.69%> (+32.27%) ⬆️
linux-nightly 71.27% <7.69%> (+32.00%) ⬆️
macos 50.66% <7.69%> (?)
pytests 1.57% <0.00%> (-0.01%) ⬇️
sanity-checks 1.38% <0.00%> (-0.01%) ⬇️
unittests 64.28% <7.69%> (?)
upgradability 0.21% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wacban wacban enabled auto-merge November 11, 2024 16:18
@wacban wacban added this pull request to the merge queue Nov 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 11, 2024
@wacban wacban added this pull request to the merge queue Nov 11, 2024
Merged via the queue into master with commit a844646 Nov 11, 2024
29 of 30 checks passed
@wacban wacban deleted the waclaw-cc branch November 11, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants