-
Notifications
You must be signed in to change notification settings - Fork 664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(congestion_control) - relax congestion control - part 2 #12430
Conversation
I plan to cut the branch tomorrow my morning, so that this change would still get in if it is merged today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving to unblock. Seen the zulip thread that 400Pgas is fine.
But I do not fully get what are implications of that so it would be best if someone that understand it approve this PR too.
Sanity check, is max_congestion_incoming_gas: 9_223_372_036_854_775_807
in
core/parameters/res/runtime_configs/parameters.yaml
an original value that was changed in later protocol versions, and we do not have to change it in this file?
@@ -208,7 +208,7 @@ vm_kind NearVm | |||
eth_implicit_accounts true | |||
yield_resume true | |||
discard_custom_sections true | |||
max_congestion_incoming_gas 40_000_000_000_000_000 | |||
max_congestion_incoming_gas 400_000_000_000_000_000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we edit this file? There is a note in 3rd line that we should not edit it 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is autogenerated and I did indeed generate it. For more context please see
nearcore/core/parameters/res/README.md
Lines 23 to 25 in f4db1e0
The latest values of parameters can be found in `parameters.snap`. This file is | |
automatically generated by tests and needs to be reviewed and committed whenever | |
any of the parameters changes. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12430 +/- ##
===========================================
+ Coverage 39.74% 71.68% +31.93%
===========================================
Files 842 843 +1
Lines 170756 170778 +22
Branches 170756 170778 +22
===========================================
+ Hits 67872 122425 +54553
+ Misses 98642 42985 -55657
- Partials 4242 5368 +1126
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
relaxing the congestion control to allow more gas (receipts) in the delayed receipts queue.
Please note I'm adding it directly to protocol version 73 because it wasn't released yet. @staffik Will it be possible to get it into 2.4?