Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

network: remove tier3_request_queue #12353

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

saketh-are
Copy link
Collaborator

@saketh-are saketh-are commented Oct 30, 2024

Incoming state part requests are throttled by the view client actor, which drops excess requests to avoid overloading the resources of the node. This PR removes the additional layer of queueing on the network side of things. There is little benefit from queueing:

  • State part requests are made at a regular rate over a long period of time and distributed well across nodes; there is no need for serving nodes to modulate spikes in demand
  • If the steady flow of incoming requests is too high for the view client's throttling rate, queueing will change which requests are served but does not increase how many requests are served; there is no benefit in that

and a major downside:

  • Queueing makes response time less predictable, forcing the requesting node to wait longer before deciding that a request was dropped/failed/lost

The queue served a secondary purpose, which is that it allowed PeerActors receiving state part requests to hand them off to the PeerManagerActor. Instead we set up an adapter so that the requests can be passed as actix messages.

@saketh-are saketh-are marked this pull request as ready for review October 30, 2024 21:05
@saketh-are saketh-are requested a review from a team as a code owner October 30, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant