-
Notifications
You must be signed in to change notification settings - Fork 622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Epoch Sync] Verify merkle proofs for the first block in current epoch. #12330
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12330 +/- ##
==========================================
- Coverage 71.25% 71.21% -0.05%
==========================================
Files 838 839 +1
Lines 169020 169777 +757
Branches 169020 169777 +757
==========================================
+ Hits 120442 120908 +466
- Misses 43338 43615 +277
- Partials 5240 5254 +14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Could you remind what happens if last final block of current epoch has not been endorsed by next epoch's block producers?
@staffik it doesn't matter; as long as the current epoch's block producers endorsed it, it is valid. |
@Longarithm @shreyan-gupta could I please get a review on this - thank you!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving to unblock. Took a high level look and lgtm, however would be nice for someone to take a more detailed look.
is_well_formed()
to facilitate that validation.