Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(state sync): record latency of p2p state requests #12323

Merged
merged 3 commits into from
Oct 28, 2024

Conversation

saketh-are
Copy link
Collaborator

Analogous to STATE_SYNC_EXTERNAL_PARTS_REQUEST_DELAY metric for centralized state sync.

Copy link

codecov bot commented Oct 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Project coverage is 71.24%. Comparing base (ad92548) to head (e45b5ea).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
chain/client/src/metrics.rs 0.00% 9 Missing ⚠️
chain/client/src/sync/state/network.rs 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12323      +/-   ##
==========================================
- Coverage   71.25%   71.24%   -0.02%     
==========================================
  Files         838      838              
  Lines      169020   169033      +13     
  Branches   169020   169033      +13     
==========================================
- Hits       120436   120421      -15     
- Misses      43346    43370      +24     
- Partials     5238     5242       +4     
Flag Coverage Δ
backward-compatibility 0.16% <0.00%> (-0.01%) ⬇️
db-migration 0.16% <0.00%> (-0.01%) ⬇️
genesis-check 1.23% <0.00%> (-0.01%) ⬇️
integration-tests 39.02% <0.00%> (-0.01%) ⬇️
linux 70.69% <0.00%> (-0.01%) ⬇️
linux-nightly 70.82% <0.00%> (-0.02%) ⬇️
macos 50.38% <0.00%> (-0.01%) ⬇️
pytests 1.54% <0.00%> (-0.01%) ⬇️
sanity-checks 1.35% <0.00%> (-0.01%) ⬇️
unittests 64.20% <0.00%> (-0.01%) ⬇️
upgradability 0.21% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@saketh-are saketh-are marked this pull request as ready for review October 27, 2024 19:50
@saketh-are saketh-are requested a review from a team as a code owner October 27, 2024 19:50
@saketh-are saketh-are added this pull request to the merge queue Oct 28, 2024
Merged via the queue into near:master with commit 251d636 Oct 28, 2024
27 of 29 checks passed
@saketh-are saketh-are deleted the measure-p2p-sync-latency branch October 28, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants