docs(state-sync): document the the fields of the state sync header #12063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nc header This part is a little light on comments, so it'll be helpful to add comments explaining what these fields are, so that when we make changes to state sync, we can be on the same page about what we're changing
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12063 +/- ##
==========================================
+ Coverage 71.40% 71.59% +0.19%
==========================================
Files 814 818 +4
Lines 163936 164532 +596
Branches 163936 164532 +596
==========================================
+ Hits 117055 117801 +746
+ Misses 41754 41590 -164
- Partials 5127 5141 +14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@VanBarbascu friendly ping :) |
VanBarbascu
approved these changes
Oct 28, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This part is a little light on comments, so it'll be helpful to add comments explaining what these fields are, so that when we make changes to state sync, we can be on the same page about what we're changing