Dynamically remove validator key #12011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12011 +/- ##
==========================================
+ Coverage 71.51% 71.52% +0.01%
==========================================
Files 812 814 +2
Lines 164491 164631 +140
Branches 164491 164631 +140
==========================================
+ Hits 117634 117760 +126
- Misses 41701 41708 +7
- Partials 5156 5163 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
akhi3030
approved these changes
Aug 28, 2024
core/dyn-configs/src/lib.rs
Outdated
| pub validator_signer: Option<Arc<ValidatorSigner>>, | ||
| /// `None` means that the validator key existence could not be determined. | ||
| /// `Some(None)` means that it was determined that the validator key does not exist. | ||
| pub validator_signer: Option<Option<Arc<ValidatorSigner>>>, |
There was a problem hiding this comment.
I wonder if it makes sense to use a custom enum here instead. Parsing Option<Option<Foo>> feels too cumbersome compared to having a enum with specific variants.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #11995
Adds support to dynamically remove validator key.