Do not mandate use of SHA-NI instruction #11973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #11973 +/- ##
==========================================
- Coverage 71.59% 71.54% -0.06%
==========================================
Files 808 810 +2
Lines 163588 163865 +277
Branches 163588 163865 +277
==========================================
+ Hits 117125 117238 +113
- Misses 41381 41548 +167
+ Partials 5082 5079 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
nagisa
force-pushed
the
fix-cpu-features
branch
from
506ba32 to
a49124e
Compare
nagisa
changed the title
That said, development currently happens on machines with this instruction enabled and our fee structure will assume use of this instruction in the long run, meaning that this instruction will become required to keep up with the network in due time anyway. This also fixes other feature names. I had looked at the LLVM names, rather than Rust ones in the list 🤦
bowenwang1996
approved these changes
Aug 20, 2024
nagisa
force-pushed
the
fix-cpu-features
branch
from
a49124e to
1c62ae0
Compare
|
Thank you! This gives me time to upgrade my server. |
jancionear
pushed a commit
that referenced
this pull request
Aug 21, 2024
That said, development currently happens on machines with this instruction enabled and our fee structure will assume use of this instruction in the long run, meaning that this instruction will become required to keep up with the network in due time anyway. This also fixes other feature names. I had looked at the LLVM names, rather than Rust ones in the list 🤦
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That said, development currently happens on machines with this
instruction enabled and our fee structure will assume use of this
instruction in the long run, meaning that this instruction will become
required to keep up with the network in due time anyway.
This also fixes other feature names. I had looked at the LLVM names,
rather than Rust ones in the list 🤦