-
Notifications
You must be signed in to change notification settings - Fork 659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Panic in debug mode or non-prod chain when there is a chunk-witness validation error #11412
Panic in debug mode or non-prod chain when there is a chunk-witness validation error #11412
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11412 +/- ##
=======================================
Coverage 71.36% 71.36%
=======================================
Files 784 784
Lines 158108 158121 +13
Branches 158108 158121 +13
=======================================
+ Hits 112837 112849 +12
- Misses 40401 40407 +6
+ Partials 4870 4865 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address my comment above but otherwise looks good
This is an attempt to create a submittable version of this commit.
After this change chunk-witness validation errors will lead to panic for non-production chains (eg. mocknet and localnet). mainnet and testnet will continue to log error and continue on validation errors.
We also add a method to enable/disable this for tests, especially for adversarial behavior where the chunk validation errors are intended as part of the test scenario.