Improve some tracing spans #10774
Merged
Improve some tracing spans #10774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a span and improve the naming of another
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #10774 +/- ##
==========================================
+ Coverage 71.72% 71.73% +0.01%
==========================================
Files 758 758
Lines 152795 152795
Branches 152795 152795
==========================================
+ Hits 109589 109610 +21
+ Misses 38220 38198 -22
- Partials 4986 4987 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Co-authored-by: Simonas Kazlauskas <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 14, 2024
This instruments the `StoreCompiledContractCache` to show an overall cost of these operations whenever they are used. The level I've chosen here is `trace` to avoid polluting the traces too much in default operation. #10774 has a targeted instrumentation at a higher level.
nagisa
added a commit
to nagisa/nearcore
that referenced
this pull request
Mar 20, 2024
This instruments the `StoreCompiledContractCache` to show an overall cost of these operations whenever they are used. The level I've chosen here is `trace` to avoid polluting the traces too much in default operation. near#10774 has a targeted instrumentation at a higher level.
VanBarbascu
pushed a commit
that referenced
this pull request
Mar 26, 2024
This instruments the `StoreCompiledContractCache` to show an overall cost of these operations whenever they are used. The level I've chosen here is `trace` to avoid polluting the traces too much in default operation. #10774 has a targeted instrumentation at a higher level.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a span and improve the naming of another