-
Notifications
You must be signed in to change notification settings - Fork 664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Clone derive for primitive structs #10730
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khorolets
approved these changes
Mar 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is something developers from the community have been dreaming for last ~4 years 😅
Longarithm
approved these changes
Mar 8, 2024
kobayurii
added a commit
to kobayurii/nearcore
that referenced
this pull request
Mar 20, 2024
This pull request adds the Clone derive for specified primitive structs, enabling easy creation of deep copies. It improves usability, consistency, and readability while adhering to Rust conventions. **Why This Matters:** - **Enhanced Usability:** With the `Clone` trait implemented, users can easily create copies of these structs without manually implementing the clone functionality, which improves usability and reduces boilerplate code. - **Consistency and Readability:** By ensuring consistency in our codebase and following Rust conventions, we enhance code readability and maintainability. - **Performance:** While cloning can incur performance overhead, it's often necessary in certain contexts, and having it readily available can streamline development processes.
khorolets
pushed a commit
that referenced
this pull request
Apr 4, 2024
This pull request adds the Clone derive for specified primitive structs, enabling easy creation of deep copies. It improves usability, consistency, and readability while adhering to Rust conventions. **Why This Matters:** - **Enhanced Usability:** With the `Clone` trait implemented, users can easily create copies of these structs without manually implementing the clone functionality, which improves usability and reduces boilerplate code. - **Consistency and Readability:** By ensuring consistency in our codebase and following Rust conventions, we enhance code readability and maintainability. - **Performance:** While cloning can incur performance overhead, it's often necessary in certain contexts, and having it readily available can streamline development processes.
khorolets
pushed a commit
that referenced
this pull request
Apr 9, 2024
This pull request adds the Clone derive for specified primitive structs, enabling easy creation of deep copies. It improves usability, consistency, and readability while adhering to Rust conventions. **Why This Matters:** - **Enhanced Usability:** With the `Clone` trait implemented, users can easily create copies of these structs without manually implementing the clone functionality, which improves usability and reduces boilerplate code. - **Consistency and Readability:** By ensuring consistency in our codebase and following Rust conventions, we enhance code readability and maintainability. - **Performance:** While cloning can incur performance overhead, it's often necessary in certain contexts, and having it readily available can streamline development processes.
kobayurii
added a commit
to kobayurii/nearcore
that referenced
this pull request
Apr 9, 2024
This pull request adds the Clone derive for specified primitive structs, enabling easy creation of deep copies. It improves usability, consistency, and readability while adhering to Rust conventions. **Why This Matters:** - **Enhanced Usability:** With the `Clone` trait implemented, users can easily create copies of these structs without manually implementing the clone functionality, which improves usability and reduces boilerplate code. - **Consistency and Readability:** By ensuring consistency in our codebase and following Rust conventions, we enhance code readability and maintainability. - **Performance:** While cloning can incur performance overhead, it's often necessary in certain contexts, and having it readily available can streamline development processes.
kobayurii
added a commit
to kobayurii/nearcore
that referenced
this pull request
Apr 23, 2024
This pull request adds the Clone derive for specified primitive structs, enabling easy creation of deep copies. It improves usability, consistency, and readability while adhering to Rust conventions. **Why This Matters:** - **Enhanced Usability:** With the `Clone` trait implemented, users can easily create copies of these structs without manually implementing the clone functionality, which improves usability and reduces boilerplate code. - **Consistency and Readability:** By ensuring consistency in our codebase and following Rust conventions, we enhance code readability and maintainability. - **Performance:** While cloning can incur performance overhead, it's often necessary in certain contexts, and having it readily available can streamline development processes.
khorolets
pushed a commit
that referenced
this pull request
Apr 23, 2024
This pull request adds the Clone derive for specified primitive structs, enabling easy creation of deep copies. It improves usability, consistency, and readability while adhering to Rust conventions. **Why This Matters:** - **Enhanced Usability:** With the `Clone` trait implemented, users can easily create copies of these structs without manually implementing the clone functionality, which improves usability and reduces boilerplate code. - **Consistency and Readability:** By ensuring consistency in our codebase and following Rust conventions, we enhance code readability and maintainability. - **Performance:** While cloning can incur performance overhead, it's often necessary in certain contexts, and having it readily available can streamline development processes.
kobayurii
added a commit
to kobayurii/nearcore
that referenced
this pull request
May 13, 2024
This pull request adds the Clone derive for specified primitive structs, enabling easy creation of deep copies. It improves usability, consistency, and readability while adhering to Rust conventions. **Why This Matters:** - **Enhanced Usability:** With the `Clone` trait implemented, users can easily create copies of these structs without manually implementing the clone functionality, which improves usability and reduces boilerplate code. - **Consistency and Readability:** By ensuring consistency in our codebase and following Rust conventions, we enhance code readability and maintainability. - **Performance:** While cloning can incur performance overhead, it's often necessary in certain contexts, and having it readily available can streamline development processes.
kobayurii
added a commit
to kobayurii/nearcore
that referenced
this pull request
May 13, 2024
This pull request adds the Clone derive for specified primitive structs, enabling easy creation of deep copies. It improves usability, consistency, and readability while adhering to Rust conventions. **Why This Matters:** - **Enhanced Usability:** With the `Clone` trait implemented, users can easily create copies of these structs without manually implementing the clone functionality, which improves usability and reduces boilerplate code. - **Consistency and Readability:** By ensuring consistency in our codebase and following Rust conventions, we enhance code readability and maintainability. - **Performance:** While cloning can incur performance overhead, it's often necessary in certain contexts, and having it readily available can streamline development processes.
kobayurii
added a commit
to kobayurii/nearcore
that referenced
this pull request
May 13, 2024
This pull request adds the Clone derive for specified primitive structs, enabling easy creation of deep copies. It improves usability, consistency, and readability while adhering to Rust conventions. **Why This Matters:** - **Enhanced Usability:** With the `Clone` trait implemented, users can easily create copies of these structs without manually implementing the clone functionality, which improves usability and reduces boilerplate code. - **Consistency and Readability:** By ensuring consistency in our codebase and following Rust conventions, we enhance code readability and maintainability. - **Performance:** While cloning can incur performance overhead, it's often necessary in certain contexts, and having it readily available can streamline development processes.
kobayurii
added a commit
to kobayurii/nearcore
that referenced
this pull request
May 13, 2024
This pull request adds the Clone derive for specified primitive structs, enabling easy creation of deep copies. It improves usability, consistency, and readability while adhering to Rust conventions. **Why This Matters:** - **Enhanced Usability:** With the `Clone` trait implemented, users can easily create copies of these structs without manually implementing the clone functionality, which improves usability and reduces boilerplate code. - **Consistency and Readability:** By ensuring consistency in our codebase and following Rust conventions, we enhance code readability and maintainability. - **Performance:** While cloning can incur performance overhead, it's often necessary in certain contexts, and having it readily available can streamline development processes.
kobayurii
added a commit
to kobayurii/nearcore
that referenced
this pull request
May 14, 2024
This pull request adds the Clone derive for specified primitive structs, enabling easy creation of deep copies. It improves usability, consistency, and readability while adhering to Rust conventions. **Why This Matters:** - **Enhanced Usability:** With the `Clone` trait implemented, users can easily create copies of these structs without manually implementing the clone functionality, which improves usability and reduces boilerplate code. - **Consistency and Readability:** By ensuring consistency in our codebase and following Rust conventions, we enhance code readability and maintainability. - **Performance:** While cloning can incur performance overhead, it's often necessary in certain contexts, and having it readily available can streamline development processes.
kobayurii
added a commit
to kobayurii/nearcore
that referenced
this pull request
May 14, 2024
This pull request adds the Clone derive for specified primitive structs, enabling easy creation of deep copies. It improves usability, consistency, and readability while adhering to Rust conventions. **Why This Matters:** - **Enhanced Usability:** With the `Clone` trait implemented, users can easily create copies of these structs without manually implementing the clone functionality, which improves usability and reduces boilerplate code. - **Consistency and Readability:** By ensuring consistency in our codebase and following Rust conventions, we enhance code readability and maintainability. - **Performance:** While cloning can incur performance overhead, it's often necessary in certain contexts, and having it readily available can streamline development processes.
kobayurii
added a commit
to kobayurii/nearcore
that referenced
this pull request
May 14, 2024
This pull request adds the Clone derive for specified primitive structs, enabling easy creation of deep copies. It improves usability, consistency, and readability while adhering to Rust conventions. **Why This Matters:** - **Enhanced Usability:** With the `Clone` trait implemented, users can easily create copies of these structs without manually implementing the clone functionality, which improves usability and reduces boilerplate code. - **Consistency and Readability:** By ensuring consistency in our codebase and following Rust conventions, we enhance code readability and maintainability. - **Performance:** While cloning can incur performance overhead, it's often necessary in certain contexts, and having it readily available can streamline development processes.
kobayurii
added a commit
to kobayurii/nearcore
that referenced
this pull request
May 14, 2024
This pull request adds the Clone derive for specified primitive structs, enabling easy creation of deep copies. It improves usability, consistency, and readability while adhering to Rust conventions. **Why This Matters:** - **Enhanced Usability:** With the `Clone` trait implemented, users can easily create copies of these structs without manually implementing the clone functionality, which improves usability and reduces boilerplate code. - **Consistency and Readability:** By ensuring consistency in our codebase and following Rust conventions, we enhance code readability and maintainability. - **Performance:** While cloning can incur performance overhead, it's often necessary in certain contexts, and having it readily available can streamline development processes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the Clone derive for specified primitive structs, enabling easy creation of deep copies. It improves usability, consistency, and readability while adhering to Rust conventions.
Why This Matters:
Enhanced Usability: With the
Clone
trait implemented, users can easily create copies of these structs without manually implementing the clone functionality, which improves usability and reduces boilerplate code.Consistency and Readability: By ensuring consistency in our codebase and following Rust conventions, we enhance code readability and maintainability.
Performance: While cloning can incur performance overhead, it's often necessary in certain contexts, and having it readily available can streamline development processes.