-
Notifications
You must be signed in to change notification settings - Fork 622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: clean orphaned witnesses below the last final height #10658
Conversation
Orphaned witnesses which are below the final height of the chain will never be processed, so let's remove them from the orphan pool to save memory. Fixes: near#10649
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #10658 +/- ##
==========================================
- Coverage 72.42% 72.28% -0.15%
==========================================
Files 732 732
Lines 149935 150403 +468
Branches 149935 150403 +468
==========================================
+ Hits 108594 108712 +118
- Misses 36421 36751 +330
- Partials 4920 4940 +20
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mini nit: Maybe rename process_ready_orphan_chunk_state_witnesses
or mention in a comment that it also handles cleanup. optional
Yeah, the old name doesn't reflect the new functionality, renamed to |
Orphaned witnesses which are below the final height of the chain will never be processed, so let's remove them from the orphan pool to free up memory.
Fixes: #10649