feat: clean orphaned witnesses below the last final height

[jancionear]

Orphaned witnesses which are below the final height of the chain will never be processed, so let's remove them from the orphan pool to free up memory.

Fixes: #10649

[codecov]

Codecov Report

Attention: Patch coverage is 85.93750% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 72.28%. Comparing base (8383deb) to head (5fd35e1).
Report is 4 commits behind head on master.

Files	Patch %	Lines
..._validation/chunk_validator/orphan_witness_pool.rs	81.25%	8 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #10658      +/-   ##
==========================================
- Coverage   72.42%   72.28%   -0.15%     
==========================================
  Files         732      732              
  Lines      149935   150403     +468     
  Branches   149935   150403     +468     
==========================================
+ Hits       108594   108712     +118     
- Misses      36421    36751     +330     
- Partials     4920     4940      +20     

Flag	Coverage Δ
backward-compatibility	0.24% <0.00%> (-0.01%)	⬇️
db-migration	0.24% <0.00%> (-0.01%)	⬇️
genesis-check	1.42% <0.00%> (-0.01%)	⬇️
integration-tests	36.98% <29.68%> (+<0.01%)	⬆️
linux	71.08% <85.93%> (-0.13%)	⬇️
linux-nightly	71.72% <85.93%> (-0.12%)	⬇️
macos	55.34% <85.93%> (-0.11%)	⬇️
pytests	1.64% <0.00%> (-0.01%)	⬇️
sanity-checks	1.42% <0.00%> (-0.01%)	⬇️
unittests	68.12% <85.93%> (-0.14%)	⬇️
upgradability	0.28% <0.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[wacban]

LGTM

mini nit: Maybe rename process_ready_orphan_chunk_state_witnesses or mention in a comment that it also handles cleanup. optional

[jancionear]

mini nit: Maybe rename process_ready_orphan_chunk_state_witnesses or mention in a comment that it also handles cleanup. optional

Yeah, the old name doesn't reflect the new functionality, renamed to process_ready_orphan_witnesses_and_clean_old