Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hacky way to retry applying orphan state witness if the parent block doesn't yet exist #10535

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Hacky way to retry applying orphan state witness if the parent block doesn't yet exist #10535

merged 1 commit into from
Jan 31, 2024

Conversation

robin-near
Copy link
Contributor

No description provided.

@robin-near robin-near requested a review from a team as a code owner January 31, 2024 05:52
@codecov Codecov
Copy link

codecov bot commented Jan 31, 2024

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (d3ea7ed) 71.87% compared to head (7f8d649) 71.86%.

Files Patch % Lines
chain/client/src/client_actor.rs 0.00% 12 Missing ⚠️
...client/src/stateless_validation/chunk_validator.rs 83.33% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #10535      +/-   ##
==========================================
- Coverage   71.87%   71.86%   -0.01%     
==========================================
  Files         723      723              
  Lines      146944   146960      +16     
  Branches   146944   146960      +16     
==========================================
- Hits       105617   105614       -3     
- Misses      36460    36478      +18     
- Partials     4867     4868       +1
Flag Coverage Δ
backward-compatibility 0.08% <0.00%> (-0.01%) ⬇️
db-migration 0.08% <0.00%> (-0.01%) ⬇️
genesis-check 1.25% <0.00%> (-0.01%) ⬇️
integration-tests 36.84% <40.90%> (+<0.01%) ⬆️
linux 71.00% <0.00%> (-0.07%) ⬇️
linux-nightly 71.25% <40.90%> (+0.03%) ⬆️
macos 54.98% <0.00%> (+0.01%) ⬆️
pytests 1.47% <0.00%> (-0.01%) ⬇️
sanity-checks 1.26% <0.00%> (-0.01%) ⬇️
unittests 67.83% <0.00%> (-0.02%) ⬇️
upgradability 0.13% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Longarithm
Longarithm approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@Longarithm Longarithm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge it ASAP and later work on proper solution to this.

@Longarithm Longarithm added this pull request to the merge queue Jan 31, 2024
Merged via the queue into near:master with commit ef5564c Jan 31, 2024
26 of 28 checks passed
@shreyan-gupta shreyan-gupta added the A-stateless-validation Area: stateless validation label Jan 31, 2024
This was referenced Feb 2, 2024
Closed
Open
jancionear added a commit to jancionear/nearcore that referenced this pull request Feb 14, 2024
@jancionear
Remove witness retrying logic on missing block
a4c4f24 
Sometimes when we would like to process a ChunkStateWitness the
block required to process it isn't available yet, we have to wait
for it. near#10535 implemented a
hacky way to do it by retrying the processing every 500ms until the
required block arrives. This PR will implement a proper solution, so
let's remove the hacky workaround.
jancionear added a commit to jancionear/nearcore that referenced this pull request Feb 20, 2024
@jancionear
Remove witness retrying logic on missing block
b1b2e71 
Sometimes when we would like to process a ChunkStateWitness the
block required to process it isn't available yet, we have to wait
for it. near#10535 implemented a
hacky way to do it by retrying the processing every 500ms until the
required block arrives. This PR will implement a proper solution, so
let's remove the hacky workaround.
jancionear added a commit to jancionear/nearcore that referenced this pull request Feb 21, 2024
@jancionear
Remove witness retrying logic on missing block
05d44fa 
Sometimes when we would like to process a ChunkStateWitness the
block required to process it isn't available yet, we have to wait
for it. near#10535 implemented a
hacky way to do it by retrying the processing every 500ms until the
required block arrives. This PR will implement a proper solution, so
let's remove the hacky workaround.
jancionear added a commit to jancionear/nearcore that referenced this pull request Feb 21, 2024
@jancionear
Remove witness retrying logic on missing block
74253c0 
Sometimes when a ChunkStateWitness arrives to be processed, the
block required to process it isn't available yet, we have to wait
for it. near#10535 implemented a
hacky way to do it by retrying the processing every 500ms until the
required block arrives. This PR will implement a proper solution, so
let's remove the hacky workaround.
jancionear added a commit to jancionear/nearcore that referenced this pull request Feb 21, 2024
@jancionear
Remove witness retrying logic on missing block
8dd0c4e 
Sometimes when a ChunkStateWitness arrives to be processed, the
block required to process it isn't available yet, we have to wait
for it. near#10535 implemented a
hacky way to do it by retrying the processing every 500ms until the
required block arrives. This PR will implement a proper solution, so
let's remove the hacky workaround.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Longarithm Longarithm Longarithm approved these changes

Assignees
No one assigned
Labels
A-stateless-validation Area: stateless validation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robin-near @Longarithm @shreyan-gupta