[stateless_validaiton] Skip validation of state witness for chunk right after genesis #10487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #10487 +/- ##
========================================
Coverage 71.93% 71.94%
========================================
Files 720 720
Lines 145620 145776 +156
Branches 145620 145776 +156
========================================
+ Hits 104755 104872 +117
- Misses 36057 36082 +25
- Partials 4808 4822 +14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Longarithm
approved these changes
Jan 24, 2024
| @@ -421,10 +407,54 @@ fn apply_result_to_chunk_extra( | |||
| ) | |||
| } | |||
|
|
|||
| fn send_chunk_endorsement_to_block_producers( | |||
There was a problem hiding this comment.
We could name it endorse_chunk for demonstrativeness. Not a strong opinion
There was a problem hiding this comment.
I like the current name as it's more explicit
Co-authored-by: Aleksandr Logunov <[email protected]>
shreyan-gupta
deleted the
shreyan/stateless_validation/skip_validate_genesis
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are skipping state witness validation for the chunk right after genesis chunk due to some complications of trying to run the genesis chunk in runtime (it's not possible to do so).
Initially this edge case check was a part of
send_chunk_state_witness_to_chunk_validatorsand we didn't send state witness at all.This has an issue that we do not process and send chunk endorsements either due to this. Instead pushed this check into
process_chunk_state_witnessand we send chunk endorsements for this special case.