-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[refactor] Move garbage collection related code into a separate file #10361
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #10361 +/- ##
========================================
Coverage 71.90% 71.91%
========================================
Files 716 717 +1
Lines 143750 143542 -208
Branches 143750 143542 -208
========================================
- Hits 103368 103222 -146
+ Misses 35632 35570 -62
Partials 4750 4750
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! While you're at it, maybe you can move the GC tests into yet another file maybe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and thanks for taking time to do this!
nit: could you please mention #10275 in the description
Thanks Akhi! After your comment, I realized we already had a file tests/gc.rs for garbage collection related tests. I shifted all current gc related test from store.rs to that file! |
Trying to push all things GC into a separate file.
This is part of the efforts highlighted in issue #10275