Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] Move garbage collection related code into a separate file #10361

Merged
merged 2 commits into from
Dec 21, 2023

Conversation

shreyan-gupta
Copy link
Contributor

@shreyan-gupta shreyan-gupta commented Dec 21, 2023

Trying to push all things GC into a separate file.

This is part of the efforts highlighted in issue #10275

@shreyan-gupta shreyan-gupta requested a review from a team as a code owner December 21, 2023 05:29
Copy link

codecov bot commented Dec 21, 2023

Codecov Report

Attention: 129 lines in your changes are missing coverage. Please review.

Comparison is base (38efea2) 71.90% compared to head (11f0574) 71.91%.
Report is 6 commits behind head on master.

Files Patch % Lines
chain/chain/src/garbage_collection.rs 81.49% 54 Missing and 72 partials ⚠️
chain/chain/src/store.rs 50.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master   #10361    +/-   ##
========================================
  Coverage   71.90%   71.91%            
========================================
  Files         716      717     +1     
  Lines      143750   143542   -208     
  Branches   143750   143542   -208     
========================================
- Hits       103368   103222   -146     
+ Misses      35632    35570    -62     
  Partials     4750     4750            
Flag Coverage Δ
backward-compatibility 0.08% <0.00%> (-0.01%) ⬇️
db-migration 0.08% <0.00%> (-0.01%) ⬇️
genesis-check 1.25% <0.00%> (-0.01%) ⬇️
integration-tests 36.48% <77.32%> (-0.02%) ⬇️
linux 71.47% <82.05%> (+0.01%) ⬆️
linux-nightly 71.50% <82.05%> (+0.02%) ⬆️
macos 53.68% <53.40%> (-0.03%) ⬇️
pytests 1.48% <0.00%> (-0.01%) ⬇️
sanity-checks 1.28% <0.00%> (-0.01%) ⬇️
unittests 68.17% <53.40%> (-0.01%) ⬇️
upgradability 0.13% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@akhi3030 akhi3030 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! While you're at it, maybe you can move the GC tests into yet another file maybe.

Copy link
Contributor

@pugachAG pugachAG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and thanks for taking time to do this!
nit: could you please mention #10275 in the description

@shreyan-gupta
Copy link
Contributor Author

LGTM! While you're at it, maybe you can move the GC tests into yet another file maybe.

Thanks Akhi! After your comment, I realized we already had a file tests/gc.rs for garbage collection related tests. I shifted all current gc related test from store.rs to that file!

@shreyan-gupta shreyan-gupta added this pull request to the merge queue Dec 21, 2023
Merged via the queue into master with commit e703deb Dec 21, 2023
21 checks passed
@shreyan-gupta shreyan-gupta deleted the shreyan/refactor/gc branch December 21, 2023 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants