Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move runtime tests into a separate file #10274

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

pugachAG
Copy link
Contributor

@pugachAG pugachAG commented Dec 1, 2023

This PR moves NightshadeRuntime tests module into a separate file without changing anything else.

See #10275 for more context.

In case having tests as a separate file is a good idea for the following reasons:

  • these are mostly integration-style tests with heavy setup (see TestEnv) and quite a lot of code, so to me it seems like it deserves to be in a separate file
  • the code is already in mod.rs file, so we don't need to create a separate directory structure.

@pugachAG pugachAG requested a review from a team as a code owner December 1, 2023 09:55
@pugachAG pugachAG requested a review from akhi3030 December 1, 2023 09:55
Copy link
Collaborator

@akhi3030 akhi3030 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disappointed in github's UI to not provide a more sensible diff.

Can you provide a brief justification for the change please?

Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Attention: 90 lines in your changes are missing coverage. Please review.

Comparison is base (90355d4) 71.78% compared to head (e84dd94) 71.76%.

Files Patch % Lines
nearcore/src/runtime/tests.rs 92.96% 84 Missing and 6 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10274      +/-   ##
==========================================
- Coverage   71.78%   71.76%   -0.02%     
==========================================
  Files         711      712       +1     
  Lines      142936   142874      -62     
  Branches   142936   142874      -62     
==========================================
- Hits       102613   102540      -73     
- Misses      35594    35604      +10     
- Partials     4729     4730       +1     
Flag Coverage Δ
backward-compatibility 0.08% <ø> (ø)
db-migration 0.08% <ø> (ø)
genesis-check 1.26% <ø> (ø)
integration-tests 36.18% <0.00%> (+0.05%) ⬆️
linux 71.63% <92.96%> (-0.03%) ⬇️
linux-nightly 71.36% <92.96%> (-0.01%) ⬇️
macos 55.00% <92.96%> (-0.03%) ⬇️
pytests 1.48% <ø> (ø)
sanity-checks 1.28% <ø> (ø)
unittests 68.14% <92.96%> (-0.03%) ⬇️
upgradability 0.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pugachAG pugachAG added this pull request to the merge queue Dec 1, 2023
Merged via the queue into near:master with commit cbe8556 Dec 1, 2023
17 of 18 checks passed
@pugachAG pugachAG deleted the separate-runtime-tests branch December 1, 2023 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants