Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_rejoin test::test_4_20_kill1 is extremely flaky #3141

Closed
SkidanovAlex opened this issue Aug 11, 2020 · 0 comments · Fixed by #3252
Closed

test_rejoin test::test_4_20_kill1 is extremely flaky #3141

SkidanovAlex opened this issue Aug 11, 2020 · 0 comments · Fixed by #3252
Assignees
@mikhailOK

Comments

@SkidanovAlex
Copy link
Collaborator

See

http://52.149.162.182:3000/#/test_history/7713

and

http://52.149.162.182:3000/#/test_history/7714
@weekly-digest weekly-digest bot mentioned this issue Aug 14, 2020
Closed
@mikhailOK mikhailOK self-assigned this Aug 24, 2020
mikhailOK added a commit that referenced this issue Aug 24, 2020
@mikhailOK
fix(test): fix test_4_20_kill1
792145e 
Fixes #3141

Test plan
---------
test_4_20_kill1
mikhailOK added a commit that referenced this issue Aug 24, 2020
@mikhailOK
fix(test): fix test_4_20_kill1
31ee77c 
Fixes #3141

Test plan
---------
test_4_20_kill1
mikhailOK added a commit that referenced this issue Aug 24, 2020
@mikhailOK
fix(test): fix test_4_20_kill1
046cf59 
Fixes #3141

Test plan
---------
test_4_20_kill1
mikhailOK added a commit that referenced this issue Aug 25, 2020
@mikhailOK
fix(test): fix test_4_20_kill1
e093e3f 
Fixes #3141

Test plan
---------
test_4_20_kill1
mikhailOK added a commit that referenced this issue Aug 25, 2020
@mikhailOK
fix(test): fix test_4_20_kill1
8c7860e 
Fixes #3141

Test plan
---------
test_4_20_kill1
mikhailOK added a commit that referenced this issue Aug 27, 2020
@mikhailOK
fix(test): fix test_4_20_kill1
3a0bb1d 
Fixes #3141

Test plan
---------
test_4_20_kill1
mikhailOK added a commit that referenced this issue Aug 27, 2020
@mikhailOK
fix(test): fix test_4_20_kill1
480db77 
Fixes #3141
Test was failing because it tried to query nodes before they were ready.
The fix is to properly wait until the node starts.
Also increase timeouts for tests that run nodes this way.

Test plan
---------
test_4_20_kill1
@mikhailOK mikhailOK mentioned this issue Aug 27, 2020
Merged
SkidanovAlex pushed a commit that referenced this issue Aug 27, 2020
@mikhailOK
fix(test): fix test_4_20_kill1 (#3252)
1c1c019 
Fixes #3141
Test was failing because it tried to query nodes before they were ready.
The fix is to properly wait until the node starts.
Also increase timeouts for tests that run nodes this way.

Test plan
---------
test_4_20_kill1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikhailOK mikhailOK

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(test): fix test_4_20_kill1 near/nearcore
2 participants
@SkidanovAlex @mikhailOK