Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Epoch Sync] Enable epoch sync config by default #12347

Closed
Tracked by #73
robin-near opened this issue Oct 30, 2024 · 0 comments · Fixed by #12352
Closed
Tracked by #73

[Epoch Sync] Enable epoch sync config by default #12347

robin-near opened this issue Oct 30, 2024 · 0 comments · Fixed by #12352

Comments

@robin-near
Copy link
Contributor

Description

Right now it's set to false. Some nodes may have already been initialized with false. We need to set it to true. So perhaps change the flag name.
This was referenced Oct 30, 2024
Open
Merged
github-merge-queue bot pushed a commit that referenced this issue Oct 31, 2024
@robin-near
[Epoch Sync] Enable epoch sync by default in configs. (#12352)
e4e9125 
The previous config defaulted to false, which is not good, because we
want all nodes to default it to true. This change renames the fields to
"disable_..." because (1) we need a field name change to apply new
defaults because some nodes may already have reinitialized the config;
(2) defaulting a field to false is more natural and less error-prone, so
using "disable" rather than "enable" will more naturally default to
enabling.

Also document the config fields.

Closes #12347
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Epoch Sync] Enable epoch sync by default in configs. robin-near/nearcore
1 participant
@robin-near