Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove KeyValueRuntime #10678

Open
pugachAG opened this issue Feb 28, 2024 · 0 comments
Open

Remove KeyValueRuntime #10678

pugachAG opened this issue Feb 28, 2024 · 0 comments
Labels
C-housekeeping Category: Refactoring, cleanups, code quality

Comments

@pugachAG
Copy link
Contributor

pugachAG commented Feb 28, 2024 •
edited
Loading

From KeyValueRuntime rustdoc:

/// !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
/// WARNING: If you choose to use KeyValueRuntime for your tests, BE PREPARED TO
/// HAVE A BAD TIME. Use it only if you understand it to its entirety. It has
/// implicit behavior, very specific partially implemented logic, and is generally
/// incorrect. USE NightshadeRuntime WHENEVER POSSIBLE. YOU HAVE BEEN WARNED.
/// !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
@pugachAG pugachAG added the C-housekeeping Category: Refactoring, cleanups, code quality label Feb 28, 2024
@pugachAG pugachAG mentioned this issue Feb 28, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Feb 28, 2024
@pugachAG
refactor: move NightshadeRuntime to chain (#10675)
1ab5d1b 
This PR is a part of getting rid of `KeyValueRuntime` (#10678) and
`MockEpochManager` (#10634).

Currently `NightshadeRuntime` is part of `nearcore` which makes it
impossible to use it in `chain` since `chain` depends on `nearcore`. We
need to use `NightshadeRuntime` as a replacement for `KeyValueRuntime`
in `chain` tests. Ideally it would be great to move it to `node-runtime`
crate, but currently it has a lot of dependencies from `near_chain`
which makes it very challenging, so as the first step let's move it to
`chain`.

This PR includes:
* move `nearcore::runtime` to `near_chain::runtime`
* introduce `NightshadeRuntimeExt` to expose
`NightshadeRuntime::from_config` separately since `NearConfig` is part
of `nearcore`
* move `GenesisExt` test methods directly to `Genesis`, also duplicate
some constants for now (will be refactored separately to reduce size of
this PR).
* move the necessary migrations code to `chain`
@github-actions github-actions bot mentioned this issue Mar 1, 2024
Closed
This was referenced Mar 1, 2024
Merged
Merged
github-merge-queue bot pushed a commit that referenced this issue Mar 4, 2024
@pugachAG
refactor: use NightshadeRuntime in store_validator tests (#10690)
de3b87a 
Part of #10678 and #10634.
github-merge-queue bot pushed a commit that referenced this issue Mar 4, 2024
@pugachAG
refactor: use NightshadeRuntime for chain garabage collection tests (#…
6a68a2b 
…10694)

Part of #10678 and
#10634.

Tests are updated to reflect the actual behaviour of chain garbage
collection.
This was referenced Mar 16, 2024
Merged
Merged
Merged
github-merge-queue bot pushed a commit that referenced this issue Mar 18, 2024
@pugachAG
refactor: use NightshadeRuntime in chain test_utils (#10812)
fa8b74f 
Part of #10678 and
#10634.
github-merge-queue bot pushed a commit that referenced this issue Mar 18, 2024
@pugachAG
refactor: use NightshadeRuntime in telemetry_info test (#10811)
7b03a6c 
Part of #10678 and #10634.
github-merge-queue bot pushed a commit that referenced this issue Mar 18, 2024
@pugachAG
refactor: use NightshadeRuntime with network integration tests (#10810)
272797f 
Part of #10678 and
#10634.
@pugachAG pugachAG mentioned this issue Mar 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-housekeeping Category: Refactoring, cleanups, code quality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pugachAG