-
Notifications
You must be signed in to change notification settings - Fork 622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove KeyValueRuntime #10678
Labels
C-housekeeping
Category: Refactoring, cleanups, code quality
Comments
github-merge-queue bot
pushed a commit
that referenced
this issue
Feb 28, 2024
This PR is a part of getting rid of `KeyValueRuntime` (#10678) and `MockEpochManager` (#10634). Currently `NightshadeRuntime` is part of `nearcore` which makes it impossible to use it in `chain` since `chain` depends on `nearcore`. We need to use `NightshadeRuntime` as a replacement for `KeyValueRuntime` in `chain` tests. Ideally it would be great to move it to `node-runtime` crate, but currently it has a lot of dependencies from `near_chain` which makes it very challenging, so as the first step let's move it to `chain`. This PR includes: * move `nearcore::runtime` to `near_chain::runtime` * introduce `NightshadeRuntimeExt` to expose `NightshadeRuntime::from_config` separately since `NearConfig` is part of `nearcore` * move `GenesisExt` test methods directly to `Genesis`, also duplicate some constants for now (will be refactored separately to reduce size of this PR). * move the necessary migrations code to `chain`
This was referenced Mar 1, 2024
This was referenced Mar 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
From
KeyValueRuntime
rustdoc:The text was updated successfully, but these errors were encountered: