Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Too many missing chunks on StatelessNet start #10560

Closed
Longarithm opened this issue Feb 2, 2024 · 2 comments
Closed

Too many missing chunks on StatelessNet start #10560

Longarithm opened this issue Feb 2, 2024 · 2 comments
Assignees
@staffik
Labels
A-stateless-validation Area: stateless validation

Comments

@Longarithm
Copy link
Member

StatelessNet with 5 validator nodes consistently has 30-40% missing chunks per validator. It doesn't exceed current kickout threshold but it is more than was reached on adversenet test.
@Longarithm Longarithm added the A-stateless-validation Area: stateless validation label Feb 2, 2024
@Longarithm Longarithm changed the title Too much missing chunks on StatelessNet Too many missing chunks on StatelessNet start Feb 2, 2024
@Longarithm Longarithm mentioned this issue Feb 5, 2024
Closed
@staffik staffik mentioned this issue Feb 5, 2024
Merged
@staffik staffik self-assigned this Feb 5, 2024
@Longarithm
Copy link
Member Author

Notes after the weekly:

  • We didn't increase min block production delay to 1s, where it should be
  • We didn't apply Robin's fix of multiplying chunk request delay 3

That's why we could've missed it on adversenet

github-merge-queue bot pushed a commit that referenced this issue Feb 6, 2024
@staffik
[stateless_validation] fix: Pending chunk endorsement cache (#10568)
c198d8b 
Issue: #10560


https://near.zulipchat.com/#narrow/stream/407237-pagoda.2Fcore.2Fstateless-validation/topic/StatelessNet.20planning/near/419827117
> * add pending_chunk_endorsements cache to ChunkEndorsementTracker
> * if we have an error on get_chunk, add endorsements to pending cache
> * on on_chunk_completed, process all pending endorsements for chunk
hash
We discussed previously that full chunk may not be needed. But this
solution aligns well with the existing design
@Longarithm
Copy link
Member Author

@staffik thanks!
https://near.zulipchat.com/#narrow/stream/422293-pagoda.2Fcore.2Fstake-wars-iv/topic/.E2.9C.94.20Missed.20chunks.20discussion/near/420198632

@Longarithm Longarithm mentioned this issue Feb 7, 2024
Open
64 tasks
@github-actions github-actions bot mentioned this issue Mar 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@staffik staffik

Labels
A-stateless-validation Area: stateless validation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Longarithm @staffik