Skip to content

Commit

Permalink
fix(state-sync): Make partial chunks message deterministic (#9427)
Browse files Browse the repository at this point in the history
The issue only happens if a node tracks a subset of shards.
The order of shards is arbitrary because:

* Shard ids are in a HashSet
* In one case the first the node adds the shards that are cached, and later the shards that are only available on disk.
  • Loading branch information
nikurt committed Aug 30, 2023
1 parent 65eb6d2 commit 8bd1605
Showing 1 changed file with 6 additions and 4 deletions.
10 changes: 6 additions & 4 deletions docs/misc/state_sync_from_external_storage.md
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,11 @@ your `config.json` file:
}
}
},
"state_sync_timeout": {
"secs": 30,
"nanos": 0
"consensus": {
"state_sync_timeout": {
"secs": 30,
"nanos": 0
}
}
```

Expand All @@ -70,7 +72,7 @@ shards that can be downloaded in parallel during state sync.
across all shards that can be downloaded in parallel during catchup. Generally,
this number should not be higher than `num_concurrent_requests`. Keep it
reasonably low to allow the node to process chunks of other shards.
* `state_sync_timeout` determines the max duration of an attempt to download a
* `consensus.state_sync_timeout` determines the max duration of an attempt to download a
state part. Setting it too low may cause too many unsuccessful attempts.

### Amazon S3
Expand Down

0 comments on commit 8bd1605

Please sign in to comment.