Skip to content

Commit

Permalink
fix: comment test_clear_old_data_too_many_heights (#10664)
Browse files Browse the repository at this point in the history
Put correct path to this test in nayduck... and comment this test for
now, because it doesn't work with resharding data and
`MockEpochManager`. cc #10634

Later, we either should remove resharding scenario or make add_block
scenario respect epoch manager.
  • Loading branch information
Longarithm authored Feb 27, 2024
1 parent bc4a4ae commit 3053693
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 1 deletion.
7 changes: 7 additions & 0 deletions chain/chain/src/tests/garbage_collection.rs
Original file line number Diff line number Diff line change
Expand Up @@ -849,7 +849,14 @@ fn test_clear_old_data_fixed_height() {
/// Test that `gc_blocks_limit` works properly
#[test]
#[cfg_attr(not(feature = "expensive_tests"), ignore)]
#[allow(unreachable_code)]
fn test_clear_old_data_too_many_heights() {
// TODO(#10634): panics on `clear_data` -> `clear_resharding_data` ->
// `MockEpochManager::is_next_block_epoch_start` apparently because
// epoch manager is not updated at all. Should we fix it together with
// removing `MockEpochManager`?
return;

for i in 1..5 {
println!("gc_blocks_limit == {:?}", i);
test_clear_old_data_too_many_heights_common(i);
Expand Down
2 changes: 1 addition & 1 deletion nightly/expensive.txt
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ expensive integration-tests integration_tests tests::client::sync_state_nodes::s
expensive integration-tests integration_tests tests::client::sync_state_nodes::sync_state_nodes_multishard --features nightly

# other tests
expensive --timeout=300 near-chain near_chain store::tests::test_clear_old_data_too_many_heights
expensive --timeout=300 near-chain near_chain tests::garbage_collection::test_clear_old_data_too_many_heights

expensive integration-tests integration_tests tests::test_simple::test_2_10_multiple_nodes
expensive integration-tests integration_tests tests::test_simple::test_2_10_multiple_nodes --features nightly
Expand Down

0 comments on commit 3053693

Please sign in to comment.