Skip to content

Commit

Permalink
Revert "Panic in CreateSnapshotRequest handle if snapshot creation … (
Browse files Browse the repository at this point in the history
#12147)

…failed (#10765)"

This reverts commit 8a09a2a.

When the network was resharded, we added this panic in order to exit
early if there was some failure, because the node would not be able to
reshard without a valid snapshot. But now that decentralized state sync
is going to be using these snapshots (and since we're reworking how
resharding works anyway), this is no longer an error that requires a
panic, since a node should continue to operate correctly even if this
part fails.
  • Loading branch information
marcelo-gonzalez authored Sep 25, 2024
1 parent 163b486 commit 16db6ec
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions chain/chain/src/state_snapshot_actor.rs
Original file line number Diff line number Diff line change
Expand Up @@ -97,9 +97,7 @@ impl StateSnapshotActor {
));
}
Err(err) => {
tracing::error!(target: "state_snapshot", ?err, "State snapshot creation failed.\
State snapshot is needed for correct node performance if it is required by config.");
panic!("State snapshot creation failed")
tracing::error!(target: "state_snapshot", ?err, "State snapshot creation failed")
}
}
}
Expand Down

0 comments on commit 16db6ec

Please sign in to comment.