fix: Self references in abi generated code #973
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially resolves #972. But I already don't like this approach.
For one, it only works for
-> Self
,-> Vec<Self>
and-> Result<..Self..>
.Whereas, we need it to work recursively. Regardless of type or depth.
Consider something like:
Result<Option<Vec<(Self, Self)>>, Self>
or user-defined typed generics.An alternative might just be to cast to string, and replace all occurrences of
Self
with#ty
, but this is another can of worms.