Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: put legacy collections under feature flag #923

Merged
merged 5 commits into from
Oct 19, 2022

Conversation

austinabell
Copy link
Contributor

closes #869

This doesn't functionally change anything because it's enabled by default, but allows devs to remove this section, and this will be deprecated in the next major version

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Copy link
Member

@ChaoticTempest ChaoticTempest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, that one test failure for simulate_simple_approve seems weird, but maybe bringing up at least 16 sandbox nodes at the same time could make it very slow. Did you ever try upping the timeout seconds?

@@ -24,7 +24,7 @@ jobs:
- uses: Swatinem/rust-cache@v1
- run: rustup target add wasm32-unknown-unknown
- name: Test
run: cargo test --all --features unstable
run: cargo test --all --features unstable --features legacy
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

optional: it's kinda weird that --features can be supplied multiple times like this. Normally I just put --features unstable,legacy, but up to you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Put old collections under legacy feature
2 participants