Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] IterableMap implementation. #1164

Merged
merged 8 commits into from
Apr 25, 2024

Conversation

ruseinov
Copy link
Collaborator

@ruseinov ruseinov commented Apr 8, 2024

Fixes #1134

To test this version of SDK, change your Cargo.toml like this:

-near-sdk = "5.1.0"
+near-sdk = { git = "https://github.com/ruseinov/near-sdk-rs", branch = "ru/feature/iterable-map" }

@ruseinov ruseinov marked this pull request as ready for review April 12, 2024 18:13
Comment on lines +100 to +101
//? Manual implementations needed only because borsh derive is leaking field types
// https://github.com/near/borsh-rs/issues/41
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that the referenced issue is resolved, can we remove the manual implementation now?

@frol frol enabled auto-merge (squash) April 25, 2024 09:24
@frol frol merged commit 0266cf9 into near:master Apr 25, 2024
15 checks passed
@ruseinov ruseinov deleted the ru/feature/iterable-map branch April 25, 2024 09:29
@frol frol mentioned this pull request Apr 25, 2024
@frol frol mentioned this pull request Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keys iterator of the store::UnorderedMap has a huge performance drop after removing elements
2 participants