feat: Make logs easy to reason about #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
telezhnaya
reviewed
Feb 23, 2022
src/main.rs
Outdated
| drop(stats_lock); | ||
|
|
||
| let block_processing_speed: f64 = | ||
| (stats_copy.done_count as f64 - prev_done_count as f64) / interval_secs as f64; |
There was a problem hiding this comment.
I'd prefer to add braces here and in all places where you do math + casts.
It could divide by interval_secs without changing the type, and then cast the result to f64.
I don't remember the parsing order, it's better not to rely on this
There was a problem hiding this comment.
I hope I get it right, could you have a look again?
src/main.rs
Outdated
| #[derive(Debug, Clone)] | ||
| struct Stats { | ||
| pub processing: std::collections::BTreeSet<u64>, | ||
| pub done_count: u64, |
There was a problem hiding this comment.
Let's rename this variable?
blocks_processed_count or anything else
src/main.rs
Outdated
|
|
||
| const INDEXER: &str = "near_lake"; | ||
|
|
||
| #[derive(Debug, Clone)] | ||
| struct Stats { | ||
| pub processing: std::collections::BTreeSet<u64>, |
There was a problem hiding this comment.
Let's rename this variable? It's not intuitive
telezhnaya
approved these changes
Feb 23, 2022
src/main.rs
Outdated
| @@ -15,16 +15,16 @@ const INDEXER: &str = "near_lake"; | |||
|
|
|||
| #[derive(Debug, Clone)] | |||
| struct Stats { | |||
| pub processing: std::collections::BTreeSet<u64>, | |||
| pub done_count: u64, | |||
| pub blocks_processing: std::collections::BTreeSet<u64>, | |||
| @@ -15,6 +15,7 @@ aws-sdk-s3 = "0.6.0" | |||
| aws-smithy-http = "0.36.0" | |||
| clap = { version = "3.0.0-beta.5", features = ["color", "derive", "env"] } | |||
| futures = "0.3.5" | |||
| humantime = "2.1.0" | |||
There was a problem hiding this comment.
I thought about our random coffee at first 😅
src/main.rs
Outdated
| @@ -111,14 +111,14 @@ async fn lake_logger( | |||
| drop(stats_lock); | |||
|
|
|||
| let block_processing_speed: f64 = | |||
| (stats_copy.done_count as f64 - prev_done_count as f64) / interval_secs as f64; | |||
| ((stats_copy.blocks_processed_count - prev_done_count) as f64) / (interval_secs as f64); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11
Logs will be printed every 10 seconds like in
nearcoreExample:
Originally in the issue @frol said
But I don't think it'd be helpful to print a bunch of blocks height, I think the number of the currently in-progress blocks should be enough. However, we can change it later.