Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing doc tests #60

Closed
morgsmccauley opened this issue Feb 23, 2023 · 2 comments
Closed

Fix failing doc tests #60

morgsmccauley opened this issue Feb 23, 2023 · 2 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@morgsmccauley
Copy link
Contributor

Tests will now be run against PRs, but we had to disable doctest in order to make them pass. This should ideally be fixed so we can reenable them.

Here are the current failures
---- src/lib.rs - (line 115) stdout ----
error: expected expression, found `$`
 --> src/lib.rs:116:1
  |
3 | $ export AWS_ACCESS_KEY_ID=AKIAIOSFODNN7EXAMPLE
  | ^ expected expression

error: aborting due to previous error

Couldn't compile the test.
---- src/lib.rs - (line 103) stdout ----
error: expected `;`, found `aws_access_key_id`
 --> src/lib.rs:104:10
  |
3 | [default]
  |          ^ help: add `;` here
4 | aws_access_key_id=AKIAIOSFODNN7EXAMPLE
  | ----------------- unexpected token

error: expected `;`, found `aws_secret_access_key`
 --> src/lib.rs:105:39
  |
4 | aws_access_key_id=AKIAIOSFODNN7EXAMPLE
  |                                       ^ help: add `;` here
5 | aws_secret_access_key=wJalrXUtnFEMI/K7MDENG/bPxRfiCYEXAMPLEKEY
  | --------------------- unexpected token

error[E0425]: cannot find value `aws_secret_access_key` in this scope
 --> src/lib.rs:106:1
  |
5 | aws_secret_access_key=wJalrXUtnFEMI/K7MDENG/bPxRfiCYEXAMPLEKEY
  | ^^^^^^^^^^^^^^^^^^^^^
  |
help: you might have meant to introduce a new binding
  |
5 | let aws_secret_access_key=wJalrXUtnFEMI/K7MDENG/bPxRfiCYEXAMPLEKEY
  | +++

error[E0425]: cannot find value `wJalrXUtnFEMI` in this scope
 --> src/lib.rs:106:23
  |
5 | aws_secret_access_key=wJalrXUtnFEMI/K7MDENG/bPxRfiCYEXAMPLEKEY
  |                       ^^^^^^^^^^^^^ not found in this scope

error[E0425]: cannot find value `K7MDENG` in this scope
 --> src/lib.rs:106:37
  |
5 | aws_secret_access_key=wJalrXUtnFEMI/K7MDENG/bPxRfiCYEXAMPLEKEY
  |                                     ^^^^^^^ not found in this scope

error[E0425]: cannot find value `bPxRfiCYEXAMPLEKEY` in this scope
 --> src/lib.rs:106:45
  |
5 | aws_secret_access_key=wJalrXUtnFEMI/K7MDENG/bPxRfiCYEXAMPLEKEY
  |                                             ^^^^^^^^^^^^^^^^^^ not found in this scope

error: aborting due to 6 previous errors

For more information about this error, try `rustc --explain E0425`.
Couldn't compile the test.
---- src/types.rs - types::LakeConfigBuilder::mainnet (line 61) stdout ----
error[E0752]: `main` function is not allowed to be `async`
 --> src/types.rs:64:1
  |
5 | async fn main() {
  | ^^^^^^^^^^^^^^^ `main` function is not allowed to be `async`

error: aborting due to previous error

For more information about this error, try `rustc --explain E0752`.
Couldn't compile the test.
---- src/lib.rs - streamer (line 241) stdout ----
error[E0596]: cannot borrow `stream` as mutable, as it is not declared as mutable
  --> src/lib.rs:254:40
   |
13 |     let (_, stream) = near_lake_framework::streamer(config);
   |             ------ help: consider changing this to be mutable: `mut stream`
14 |
15 |     while let Some(streamer_message) = stream.recv().await {
   |                                        ^^^^^^^^^^^^^ cannot borrow as mutable

error[E0752]: `main` function is not allowed to be `async`
 --> src/lib.rs:245:1
  |
6 | async fn main() {
  | ^^^^^^^^^^^^^^^ `main` function is not allowed to be `async`

error: aborting due to 2 previous errors

Some errors have detailed explanations: E0596, E0752.
For more information about an error, try `rustc --explain E0596`.
Couldn't compile the test.
---- src/types.rs - types::LakeConfigBuilder::betanet (line 97) stdout ----
error[E0752]: `main` function is not allowed to be `async`
 --> src/types.rs:100:1
  |
5 | async fn main() {
  | ^^^^^^^^^^^^^^^ `main` function is not allowed to be `async`

error: aborting due to previous error

For more information about this error, try `rustc --explain E0752`.
Couldn't compile the test.
---- src/types.rs - types::LakeConfig (line 7) stdout ----
error[E0752]: `main` function is not allowed to be `async`
 --> src/types.rs:10:1
  |
5 | async fn main() {
  | ^^^^^^^^^^^^^^^ `main` function is not allowed to be `async`

error: aborting due to previous error

For more information about this error, try `rustc --explain E0752`.
Couldn't compile the test.
---- src/lib.rs - (line 73) stdout ----
error[E0752]: `main` function is not allowed to be `async`
 --> src/lib.rs:76:1
  |
5 | async fn main() {
  | ^^^^^^^^^^^^^^^ `main` function is not allowed to be `async`

error: aborting due to previous error

For more information about this error, try `rustc --explain E0752`.
Couldn't compile the test.
---- src/lib.rs - (line 7) stdout ----
error[E0308]: mismatched types
   --> src/lib.rs:33:4
    |
7   |   async fn main() -> Result<(), tokio::io::Error> {
    |                      ---------------------------- expected `Result<(), std::io::Error>` because of return type
...
28  | /    match sender.await {
29  | |        Ok(Ok(())) => Ok(()),
30  | |        Ok(Err(e)) => Err(e),
31  | |        Err(e) => Err(anyhow::Error::from(e)), // JoinError
32  | |    }
    | |____^ expected struct `std::io::Error`, found struct `anyhow::Error`
    |
    = note: struct `anyhow::Error` and struct `std::io::Error` have similar names, but are actually distinct types
note: struct `anyhow::Error` is defined in crate `anyhow`
   --> /Users/morganmccauley/.cargo/registry/src/github.com-1ecc6299db9ec823/anyhow-1.0.65/src/lib.rs:371:1
    |
371 | pub struct Error {
    | ^^^^^^^^^^^^^^^^
note: struct `std::io::Error` is defined in crate `std`
   --> /Users/morganmccauley/.rustup/toolchains/1.67-aarch64-apple-darwin/lib/rustlib/src/rust/library/std/src/io/error.rs:68:1
    |
68  | pub struct Error {
    | ^^^^^^^^^^^^^^^^

error: aborting due to previous error

For more information about this error, try `rustc --explain E0308`.
Couldn't compile the test.
---- src/types.rs - types::LakeConfig::s3_config (line 32) stdout ----
error[E0432]: unresolved import `http`
 --> src/types.rs:34:5
  |
4 | use http::Uri;
  |     ^^^^ use of undeclared crate or module `http`

warning: use of deprecated struct `aws_sdk_s3::Endpoint`: Use `.endpoint_url(...)` directly instead
 --> src/types.rs:33:17
  |
3 | use aws_sdk_s3::Endpoint;
  |                 ^^^^^^^^
  |
  = note: `#[warn(deprecated)]` on by default

warning: use of deprecated struct `aws_sdk_s3::Endpoint`: Use `.endpoint_url(...)` directly instead
  --> src/types.rs:42:13
   |
12 |             Endpoint::immutable("http://0.0.0.0:9000".parse::<Uri>().unwrap()))
   |             ^^^^^^^^

error[E0277]: the trait bound `Result<Endpoint, InvalidEndpointError>: ResolveEndpoint<Params>` is not satisfied
   --> src/types.rs:42:13
    |
11  |         .endpoint_resolver(
    |          ----------------- required by a bound introduced by this call
12  |             Endpoint::immutable("http://0.0.0.0:9000".parse::<Uri>().unwrap()))
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `ResolveEndpoint<Params>` is not imple
mented for `Result<Endpoint, InvalidEndpointError>`
    |
    = help: the following other types implement trait `ResolveEndpoint<Params>`:
              <&'static str as ResolveEndpoint<T>>
              <DefaultResolver as ResolveEndpoint<Params>>
              <Endpoint as ResolveEndpoint<T>>
              <aws_endpoint::EndpointShim as ResolveEndpoint<T>>
              <aws_sdk_sso::endpoint::DefaultResolver as ResolveEndpoint<aws_sdk_sso::endpoint::Params>>
              <aws_sdk_sts::endpoint::DefaultResolver as ResolveEndpoint<aws_sdk_sts::endpoint::Params>>
note: required by a bound in `aws_sdk_s3::config::Builder::endpoint_resolver`
   --> /Users/morganmccauley/.cargo/registry/src/github.com-1ecc6299db9ec823/aws-sdk-s3-0.23.0/src/config.rs:241:33
    |
241 |         endpoint_resolver: impl aws_smithy_http::endpoint::ResolveEndpoint<crate::endpoint::Params>
    |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ required by this bound in `
aws_sdk_s3::config::Builder::endpoint_resolver`

error[E0308]: mismatched types
  --> src/types.rs:40:15
   |
9  |       let mut s3_conf = aws_sdk_s3::config::Builder::from(&aws_config);
   |                         ---------------------------------------------- expected due to this value
10 |       s3_conf = s3_conf
   |  _______________^
11 | |         .endpoint_resolver(
12 | |             Endpoint::immutable("http://0.0.0.0:9000".parse::<Uri>().unwrap()))
13 | |         .build();
   | |________________^ expected struct `aws_sdk_s3::config::Builder`, found struct `aws_sdk_s3::Config`

error[E0308]: mismatched types
  --> src/types.rs:46:20
   |
16 |         .s3_config(s3_conf)
   |          --------- ^^^^^^^ expected struct `aws_sdk_s3::Config`, found struct `aws_sdk_s3::config::Builder`
   |          |
   |          arguments to this function are incorrect
   |
note: associated function defined here
  --> /Users/morganmccauley/Developer/Repositories/near-lake-framework-rs/src/types.rs:54:16
   |
54 |     pub(crate) s3_config: Option<aws_sdk_s3::config::Config>,
   |                ^^^^^^^^^

error[E0752]: `main` function is not allowed to be `async`
 --> src/types.rs:37:1
  |
7 | async fn main() {
  | ^^^^^^^^^^^^^^^ `main` function is not allowed to be `async`

error: aborting due to 5 previous errors; 2 warnings emitted

Some errors have detailed explanations: E0277, E0308, E0432, E0752.
For more information about an error, try `rustc --explain E0277`.
Couldn't compile the test.
---- src/types.rs - types::LakeConfigBuilder::s3_config (line 32) stdout ----
error[E0432]: unresolved import `http`
 --> src/types.rs:34:5
  |
4 | use http::Uri;
  |     ^^^^ use of undeclared crate or module `http`

warning: use of deprecated struct `aws_sdk_s3::Endpoint`: Use `.endpoint_url(...)` directly instead
 --> src/types.rs:33:17
  |
3 | use aws_sdk_s3::Endpoint;
  |                 ^^^^^^^^
  |
  = note: `#[warn(deprecated)]` on by default

warning: use of deprecated struct `aws_sdk_s3::Endpoint`: Use `.endpoint_url(...)` directly instead
  --> src/types.rs:42:13
   |
12 |             Endpoint::immutable("http://0.0.0.0:9000".parse::<Uri>().unwrap()))
   |             ^^^^^^^^

error[E0277]: the trait bound `Result<Endpoint, InvalidEndpointError>: ResolveEndpoint<Params>` is not satisfied
   --> src/types.rs:42:13
    |
11  |         .endpoint_resolver(
    |          ----------------- required by a bound introduced by this call
12  |             Endpoint::immutable("http://0.0.0.0:9000".parse::<Uri>().unwrap()))
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `ResolveEndpoint<Params>` is not imple
mented for `Result<Endpoint, InvalidEndpointError>`
    |
    = help: the following other types implement trait `ResolveEndpoint<Params>`:
              <&'static str as ResolveEndpoint<T>>
              <DefaultResolver as ResolveEndpoint<Params>>
              <Endpoint as ResolveEndpoint<T>>
              <aws_endpoint::EndpointShim as ResolveEndpoint<T>>
              <aws_sdk_sso::endpoint::DefaultResolver as ResolveEndpoint<aws_sdk_sso::endpoint::Params>>
              <aws_sdk_sts::endpoint::DefaultResolver as ResolveEndpoint<aws_sdk_sts::endpoint::Params>>
note: required by a bound in `aws_sdk_s3::config::Builder::endpoint_resolver`
   --> /Users/morganmccauley/.cargo/registry/src/github.com-1ecc6299db9ec823/aws-sdk-s3-0.23.0/src/config.rs:241:33
    |
241 |         endpoint_resolver: impl aws_smithy_http::endpoint::ResolveEndpoint<crate::endpoint::Params>
    |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ required by this bound in `
aws_sdk_s3::config::Builder::endpoint_resolver`

error[E0308]: mismatched types
  --> src/types.rs:40:15
   |
9  |       let mut s3_conf = aws_sdk_s3::config::Builder::from(&aws_config);
   |                         ---------------------------------------------- expected due to this value
10 |       s3_conf = s3_conf
   |  _______________^
11 | |         .endpoint_resolver(
12 | |             Endpoint::immutable("http://0.0.0.0:9000".parse::<Uri>().unwrap()))
13 | |         .build();
   | |________________^ expected struct `aws_sdk_s3::config::Builder`, found struct `aws_sdk_s3::Config`

error[E0308]: mismatched types
  --> src/types.rs:46:20
   |
16 |         .s3_config(s3_conf)
   |          --------- ^^^^^^^ expected struct `aws_sdk_s3::Config`, found struct `aws_sdk_s3::config::Builder`
   |          |
   |          arguments to this function are incorrect
   |
note: associated function defined here
  --> /Users/morganmccauley/Developer/Repositories/near-lake-framework-rs/src/types.rs:54:16
   |
54 |     pub(crate) s3_config: Option<aws_sdk_s3::config::Config>,
   |                ^^^^^^^^^

error[E0752]: `main` function is not allowed to be `async`
 --> src/types.rs:37:1
  |
7 | async fn main() {
  | ^^^^^^^^^^^^^^^ `main` function is not allowed to be `async`

error: aborting due to 5 previous errors; 2 warnings emitted

Some errors have detailed explanations: E0277, E0308, E0432, E0752.
For more information about an error, try `rustc --explain E0277`.
Couldn't compile the test.
---- src/lib.rs - (line 150) stdout ----
error[E0432]: unresolved import `http`
 --> src/lib.rs:152:5
  |
4 | use http::Uri;
  |     ^^^^ use of undeclared crate or module `http`

warning: use of deprecated struct `aws_sdk_s3::Endpoint`: Use `.endpoint_url(...)` directly instead
 --> src/lib.rs:151:17
  |
3 | use aws_sdk_s3::Endpoint;
  |                 ^^^^^^^^
  |
  = note: `#[warn(deprecated)]` on by default

warning: use of deprecated struct `aws_sdk_s3::Endpoint`: Use `.endpoint_url(...)` directly instead
  --> src/lib.rs:160:13
   |
12 |             Endpoint::immutable("http://0.0.0.0:9000".parse::<Uri>().unwrap()))
   |             ^^^^^^^^

error[E0277]: the trait bound `Result<Endpoint, InvalidEndpointError>: ResolveEndpoint<Params>` is not satisfied
   --> src/lib.rs:160:13
    |
11  |     .endpoint_resolver(
    |      ----------------- required by a bound introduced by this call
12  |             Endpoint::immutable("http://0.0.0.0:9000".parse::<Uri>().unwrap()))
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `ResolveEndpoint<Params>` is not imple
mented for `Result<Endpoint, InvalidEndpointError>`
    |
    = help: the following other types implement trait `ResolveEndpoint<Params>`:
              <&'static str as ResolveEndpoint<T>>
              <DefaultResolver as ResolveEndpoint<Params>>
              <Endpoint as ResolveEndpoint<T>>
              <aws_endpoint::EndpointShim as ResolveEndpoint<T>>
              <aws_sdk_sso::endpoint::DefaultResolver as ResolveEndpoint<aws_sdk_sso::endpoint::Params>>
              <aws_sdk_sts::endpoint::DefaultResolver as ResolveEndpoint<aws_sdk_sts::endpoint::Params>>
note: required by a bound in `aws_sdk_s3::config::Builder::endpoint_resolver`
   --> /Users/morganmccauley/.cargo/registry/src/github.com-1ecc6299db9ec823/aws-sdk-s3-0.23.0/src/config.rs:241:33
    |
241 |         endpoint_resolver: impl aws_smithy_http::endpoint::ResolveEndpoint<crate::endpoint::Params>
    |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ required by this bound in `
aws_sdk_s3::config::Builder::endpoint_resolver`

error[E0308]: mismatched types
  --> src/lib.rs:158:11
   |
9  |   let mut s3_conf = aws_sdk_s3::config::Builder::from(&aws_config);
   |                     ---------------------------------------------- expected due to this value
10 |   s3_conf = s3_conf
   |  ___________^
11 | |     .endpoint_resolver(
12 | |             Endpoint::immutable("http://0.0.0.0:9000".parse::<Uri>().unwrap()))
13 | |     .build();
   | |____________^ expected struct `aws_sdk_s3::config::Builder`, found struct `aws_sdk_s3::Config`

error[E0308]: mismatched types
  --> src/lib.rs:164:16
   |
16 |     .s3_config(s3_conf)
   |      --------- ^^^^^^^ expected struct `aws_sdk_s3::Config`, found struct `aws_sdk_s3::config::Builder`
   |      |
   |      arguments to this function are incorrect
   |
note: associated function defined here
  --> /Users/morganmccauley/Developer/Repositories/near-lake-framework-rs/src/types.rs:54:16
   |
54 |     pub(crate) s3_config: Option<aws_sdk_s3::config::Config>,
   |                ^^^^^^^^^

error[E0752]: `main` function is not allowed to be `async`
 --> src/lib.rs:155:1
  |
7 | async fn main() {
  | ^^^^^^^^^^^^^^^ `main` function is not allowed to be `async`

error: aborting due to 5 previous errors; 2 warnings emitted

Some errors have detailed explanations: E0277, E0308, E0432, E0752.
For more information about an error, try `rustc --explain E0277`.
Couldn't compile the test.
---- src/types.rs - types::LakeConfigBuilder::s3_config (line 32) stdout ----
error[E0432]: unresolved import `http`
 --> src/types.rs:34:5
  |
4 | use http::Uri;
  |     ^^^^ use of undeclared crate or module `http`

warning: use of deprecated struct `aws_sdk_s3::Endpoint`: Use `.endpoint_url(...)` directly instead
 --> src/types.rs:33:17
  |
3 | use aws_sdk_s3::Endpoint;
  |                 ^^^^^^^^
  |
  = note: `#[warn(deprecated)]` on by default

warning: use of deprecated struct `aws_sdk_s3::Endpoint`: Use `.endpoint_url(...)` directly instead
  --> src/types.rs:42:13
   |
12 |             Endpoint::immutable("http://0.0.0.0:9000".parse::<Uri>().unwrap()))
   |             ^^^^^^^^

error[E0277]: the trait bound `Result<Endpoint, InvalidEndpointError>: ResolveEndpoint<Params>` is not satisfied
   --> src/types.rs:42:13
    |
11  |         .endpoint_resolver(
    |          ----------------- required by a bound introduced by this call
12  |             Endpoint::immutable("http://0.0.0.0:9000".parse::<Uri>().unwrap()))
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `ResolveEndpoint<Params>` is not imple
mented for `Result<Endpoint, InvalidEndpointError>`
    |
    = help: the following other types implement trait `ResolveEndpoint<Params>`:
              <&'static str as ResolveEndpoint<T>>
              <DefaultResolver as ResolveEndpoint<Params>>
              <Endpoint as ResolveEndpoint<T>>
              <aws_endpoint::EndpointShim as ResolveEndpoint<T>>
              <aws_sdk_sso::endpoint::DefaultResolver as ResolveEndpoint<aws_sdk_sso::endpoint::Params>>
              <aws_sdk_sts::endpoint::DefaultResolver as ResolveEndpoint<aws_sdk_sts::endpoint::Params>>
note: required by a bound in `aws_sdk_s3::config::Builder::endpoint_resolver`
   --> /Users/morganmccauley/.cargo/registry/src/github.com-1ecc6299db9ec823/aws-sdk-s3-0.23.0/src/config.rs:241:33
    |
241 |         endpoint_resolver: impl aws_smithy_http::endpoint::ResolveEndpoint<crate::endpoint::Params>
    |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ required by this bound in 
aws_sdk_s3::config::Builder::endpoint_resolver`

error[E0308]: mismatched types
  --> src/types.rs:40:15
   |
9  |       let mut s3_conf = aws_sdk_s3::config::Builder::from(&aws_config);
   |                         ---------------------------------------------- expected due to this value
10 |       s3_conf = s3_conf
   |  _______________^
11 | |         .endpoint_resolver(
12 | |             Endpoint::immutable("http://0.0.0.0:9000".parse::<Uri>().unwrap()))
13 | |         .build();
   | |________________^ expected struct `aws_sdk_s3::config::Builder`, found struct `aws_sdk_s3::Config`

error[E0308]: mismatched types
  --> src/types.rs:46:20
   |
16 |         .s3_config(s3_conf)
   |          --------- ^^^^^^^ expected struct `aws_sdk_s3::Config`, found struct `aws_sdk_s3::config::Builder`
   |          |
   |          arguments to this function are incorrect
   |
note: associated function defined here
  --> /Users/morganmccauley/Developer/Repositories/near-lake-framework-rs/src/types.rs:54:16
   |
54 |     pub(crate) s3_config: Option<aws_sdk_s3::config::Config>,
   |                ^^^^^^^^^

error[E0752]: `main` function is not allowed to be `async`
 --> src/types.rs:37:1
  |
7 | async fn main() {
  | ^^^^^^^^^^^^^^^ `main` function is not allowed to be `async`

error: aborting due to 5 previous errors; 2 warnings emitted

Some errors have detailed explanations: E0277, E0308, E0432, E0752.
For more information about an error, try `rustc --explain E0277`.
Couldn't compile the test.
---- src/types.rs - types::LakeConfigBuilder::testnet (line 79) stdout ----
error[E0752]: `main` function is not allowed to be `async`
 --> src/types.rs:82:1
  |
5 | async fn main() {
  | ^^^^^^^^^^^^^^^ `main` function is not allowed to be `async`

error: aborting due to previous error

For more information about this error, try `rustc --explain E0752`.
Couldn't compile the test.

failures:
    src/lib.rs - (line 103)
    src/lib.rs - (line 115)
    src/lib.rs - (line 150)
    src/lib.rs - (line 7)
    src/lib.rs - (line 73)
    src/lib.rs - streamer (line 241)
    src/types.rs - types::LakeConfig (line 7)
    src/types.rs - types::LakeConfig::s3_config (line 32)
    src/types.rs - types::LakeConfigBuilder::betanet (line 97)
    src/types.rs - types::LakeConfigBuilder::mainnet (line 61)
    src/types.rs - types::LakeConfigBuilder::s3_config (line 32)
    src/types.rs - types::LakeConfigBuilder::s3_config (line 32)
    src/types.rs - types::LakeConfigBuilder::testnet (line 79)

test result: FAILED. 0 passed; 13 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.81s

error: doctest failed, to rerun pass `--doc`
@khorolets
Copy link
Member

Now I see. Most of the errors are related to the code snippets in the docs.

Some of the code in our docs is not expected to work (e.g. code snippet with the example of how to set environmental variables with S3 credentials)

We need to iterate over the doc errors and either make it a workable code piece or mark it properly using Documentation Tests :: Attributes chapter.

@khorolets khorolets added the good first issue Good for newcomers label Feb 24, 2023
@khorolets khorolets self-assigned this Mar 13, 2023
@khorolets khorolets added this to the 0.8.0 High-level update milestone Mar 13, 2023
@khorolets
Copy link
Member

It's going to be resolved in 0.8.0, related PR is #66

khorolets added a commit that referenced this issue Mar 14, 2023
* fix(tests): Resolved #60: Fix failing doc tests

* fix: add proper code annotations where possible
khorolets added a commit that referenced this issue Jun 6, 2023
* fix(tests): Resolved #60: Fix failing doc tests

* fix: add proper code annotations where possible
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants