Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated near-primitives and associated crates #122

Merged
merged 11 commits into from
Feb 24, 2023
Merged

Conversation

anthony-near
Copy link
Contributor

@anthony-near anthony-near commented Feb 23, 2023

needed for releasing the relayer used for meta transactions near/pagoda-relayer-rs#1 and cli changes near/near-cli-rs#151

@anthony-near anthony-near self-assigned this Feb 23, 2023
src/methods/mod.rs Outdated Show resolved Hide resolved
@miraclx
Copy link
Collaborator

miraclx commented Feb 23, 2023

Contextual CI error:

thread 'methods::query::tests::test_contract_execution_error' panicked at 'this is unexpected: ServerError(
    HandlerError(
        ContractExecutionError {
            vm_error: "wasm execution failed with error: MethodResolveError(MethodEmptyName)",
            block_height: 63503911,
            block_hash: 4vMwedjLwTvGGzW23qJQrbaPmNKxQ3xetKXm6s1o8isP,
        },
    ),
)', src/methods/query.rs:175:9

Looks like near/nearcore#7815 changed things a bit. And got rid of the VMResult enum that encapsulated the VMOutcome + VMError. And instead just unwrapped that into a Result from which a VMOutcome is unwrapped.

For this reason, the string inside the outcome report has changed a little.

-wasm execution failed with error: FunctionCallError(MethodResolveError(MethodEmptyName))
+wasm execution failed with error: MethodResolveError(MethodEmptyName)

@anthony-near, can you update the following lines to exclude the FunctionCallError(..) wrap:

  1. }) if vm_error.contains("FunctionCallError(MethodResolveError(MethodNotFound))")
  2. }) if vm_error.contains("FunctionCallError(MethodResolveError(MethodEmptyName))")

@miraclx miraclx changed the title updated near-primitives and associated crates from 0.15.0 -> 0.16.0 updated near-primitives and associated crates Feb 24, 2023
@miraclx miraclx merged commit ea77386 into master Feb 24, 2023
@miraclx miraclx deleted the update_near_primitives branch February 24, 2023 19:27
@miraclx miraclx mentioned this pull request Feb 24, 2023
@frol frol mentioned this pull request Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants