Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ApiKey type can be debugged without exposing the api key #120

Merged
merged 16 commits into from
Nov 17, 2022

Conversation

miraclx
Copy link
Collaborator

@miraclx miraclx commented Nov 17, 2022

Echoing the sentiment in #115 (comment).

The debug view of ApiKey shouldn't expose the key.

@miraclx miraclx requested a review from frol November 17, 2022 04:12
Base automatically changed from miraclx/relax-uuid-requirement to master November 17, 2022 14:25
@miraclx miraclx merged commit 53c8149 into master Nov 17, 2022
@miraclx miraclx deleted the miraclx/non-debuggable-api-keys branch November 17, 2022 14:34
@miraclx miraclx mentioned this pull request Feb 24, 2023
@frol frol mentioned this pull request Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants