Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: deprecate Display impl for ApiKey #117

Merged
merged 1 commit into from
Nov 17, 2022

Conversation

miraclx
Copy link
Collaborator

@miraclx miraclx commented Nov 15, 2022

Resolves #115. Removes the Display implementation on ApiKey. I would've otherwise have deprecated this, but rust does not support #[deprecated] annotations on implementations.

@miraclx miraclx merged commit ecaebd4 into master Nov 17, 2022
@miraclx miraclx deleted the miraclx/deprecate-apikey-display branch November 17, 2022 00:33
@miraclx miraclx mentioned this pull request Feb 24, 2023
@frol frol mentioned this pull request Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ApiKey::as_str() and ApiKey::to_string() are not aligned and could be misleading
1 participant