Skip to content
This repository has been archived by the owner on Oct 4, 2024. It is now read-only.

Add eslint and fix style issues #151

Merged
merged 4 commits into from
Sep 27, 2019
Merged

Add eslint and fix style issues #151

merged 4 commits into from
Sep 27, 2019

Conversation

vgrichina
Copy link
Contributor

This is to make code style consistent with nearlib

bowenwang1996
bowenwang1996 approved these changes Sep 24, 2019
View reviewed changes
Copy link
Contributor

@bowenwang1996 bowenwang1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought in Javascript/Typescript people prefer 2 space indentation.

@vgrichina
Copy link
Contributor Author

I thought in Javascript/Typescript people prefer 2 space indentation.

a lot of peeps prefer that way, but that's been mostly driven by callback hell era (before async / await) when stuff had to be super-nested.

@vgrichina vgrichina merged commit 99ad9cb into master Sep 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bowenwang1996 bowenwang1996 bowenwang1996 approved these changes

@janedegtiareva janedegtiareva janedegtiareva approved these changes

@willemneal willemneal Awaiting requested review from willemneal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vgrichina @janedegtiareva @bowenwang1996