Fix Check for Existing Beneficiary in Account Deletion & Repair CI #1009

idea404 · 2022-08-03T17:30:48Z

This PR seeks to address the following two unaddressed subjects from #999:

The conditional check during deleteAccount() now ultimately performs a view_account RPC call instead of searching for keys to determine whether a ben. account exists
The test bash script is now fixed (allowing CI to pass) as deleting an account now requires user confirmation

idea404 added 8 commits August 3, 2022 13:41

initial commit

ade51c9

add another random elem to test acc name

d4f2f78

undo random addiiton

b64265e

add sleep after account deletion

4f18e2a

add echo lines

18c6718

categorize tests in package.json

e423bdb

use yes bash command

244702a

run index.sh with bash in package.json

a094be4

idea404 requested a review from volovyks August 3, 2022 17:30

idea404 added enhancement New feature or request bug Something isn't working labels Aug 3, 2022

use printf instead of yes, more intentional

c087476

volovyks approved these changes Aug 4, 2022

View reviewed changes

volovyks merged commit e0ffe89 into master Aug 4, 2022

idea404 deleted the fix-account-exist-check branch August 5, 2022 08:24

Provide feedback