feat: displaying transaction fee #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frol
requested changes
May 5, 2024
frolvanya
commented
May 5, 2024
|
PR seems to be complete, however, there's strange bug related to tracing from "send" module. It prints "Sending transaction ..." twice 
|
frol
requested changes
May 6, 2024
…de more details about the reasons for unavailable USD equivalent
frol
previously approved these changes
May 6, 2024
…y used internally
frol
force-pushed
the
feat/added-transaction-fee
branch
from
9a3d986
to
c8f4e16
Compare
frol
previously approved these changes
May 6, 2024
auto-merge was automatically disabled
May 6, 2024 22:01
Head branch was pushed to by a user without write access
…xchange rate and completely skip the message if there is no CoinGecko API URL
frol
approved these changes
May 7, 2024
Merged
frol
added a commit
that referenced
this pull request
May 8, 2024
## 🤖 New release * `near-cli-rs`: 0.10.0 -> 0.10.1 (⚠️ minor API breaking changes) ###⚠️ `near-cli-rs` breaking changes ``` --- failure constructible_struct_adds_field: externally-constructible struct adds field --- Description: A pub struct constructible with a struct literal has a new pub field. Existing struct literals must be updated to include the new field. ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.31.0/src/lints/constructible_struct_adds_field.ron Failed in: field NetworkConfig.coingecko_url in /tmp/.tmpFTfx79/near-cli-rs/src/config/mod.rs:143 --- failure function_missing: pub fn removed or renamed --- Description: A publicly-visible function cannot be imported by its prior path. A `pub use` may have been removed, or the function itself may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.31.0/src/lints/function_missing.ron Failed in: function near_cli_rs::common::fetch_validators_api, previously in file /tmp/.tmpek4jqM/near-cli-rs/src/common.rs:1471 function near_cli_rs::common::handler_invalid_tx_error, previously in file /tmp/.tmpek4jqM/near-cli-rs/src/common.rs:1000 function near_cli_rs::common::print_action_error, previously in file /tmp/.tmpek4jqM/near-cli-rs/src/common.rs:861 function near_cli_rs::common::print_transaction_error, previously in file /tmp/.tmpek4jqM/near-cli-rs/src/common.rs:1126 function near_cli_rs::common::fetch_validators_rpc, previously in file /tmp/.tmpek4jqM/near-cli-rs/src/common.rs:1493 ``` <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [0.10.1](v0.10.0...v0.10.1) - 2024-05-07 ### Added - Display the transaction fee in NEAR and approximate $ after transaction is executed ([#333](#333)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Displaying a simple transaction fee after transaction execution
This PR closes #320