Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: displaying transaction fee #333

Merged
merged 19 commits into from
May 7, 2024

Conversation

frolvanya
Copy link
Contributor

Displaying a simple transaction fee after transaction execution
This PR closes #320

image

src/common.rs Outdated Show resolved Hide resolved
src/common.rs Outdated Show resolved Hide resolved
src/common.rs Outdated Show resolved Hide resolved
@frolvanya
Copy link
Contributor Author

PR seems to be complete, however, there's strange bug related to tracing from "send" module. It prints "Sending transaction ..." twice

#[tracing::instrument(skip_all, name = "Sending transaction ...")]

image

@frolvanya frolvanya requested a review from frol May 6, 2024 01:55
src/common.rs Outdated Show resolved Hide resolved
src/common.rs Outdated Show resolved Hide resolved
src/common.rs Outdated Show resolved Hide resolved
src/commands/config/add_connection/mod.rs Outdated Show resolved Hide resolved
@frolvanya frolvanya requested a review from frol May 6, 2024 13:22
frol
frol previously approved these changes May 6, 2024
frol
frol previously approved these changes May 6, 2024
@frol frol enabled auto-merge (squash) May 6, 2024 21:58
auto-merge was automatically disabled May 6, 2024 22:01

Head branch was pushed to by a user without write access

@frolvanya frolvanya requested a review from frol May 6, 2024 22:14
@frol frol merged commit 21001b6 into near:main May 7, 2024
9 checks passed
@frol frol mentioned this pull request May 7, 2024
frol added a commit that referenced this pull request May 8, 2024
## 🤖 New release
* `near-cli-rs`: 0.10.0 -> 0.10.1 (⚠️ minor API breaking changes)

### ⚠️ `near-cli-rs` breaking changes

```
--- failure constructible_struct_adds_field: externally-constructible struct adds field ---

Description:
A pub struct constructible with a struct literal has a new pub field. Existing struct literals must be updated to include the new field.
        ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.31.0/src/lints/constructible_struct_adds_field.ron

Failed in:
  field NetworkConfig.coingecko_url in /tmp/.tmpFTfx79/near-cli-rs/src/config/mod.rs:143

--- failure function_missing: pub fn removed or renamed ---

Description:
A publicly-visible function cannot be imported by its prior path. A `pub use` may have been removed, or the function itself may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.31.0/src/lints/function_missing.ron

Failed in:
  function near_cli_rs::common::fetch_validators_api, previously in file /tmp/.tmpek4jqM/near-cli-rs/src/common.rs:1471
  function near_cli_rs::common::handler_invalid_tx_error, previously in file /tmp/.tmpek4jqM/near-cli-rs/src/common.rs:1000
  function near_cli_rs::common::print_action_error, previously in file /tmp/.tmpek4jqM/near-cli-rs/src/common.rs:861
  function near_cli_rs::common::print_transaction_error, previously in file /tmp/.tmpek4jqM/near-cli-rs/src/common.rs:1126
  function near_cli_rs::common::fetch_validators_rpc, previously in file /tmp/.tmpek4jqM/near-cli-rs/src/common.rs:1493
```

<details><summary><i><b>Changelog</b></i></summary><p>

<blockquote>

##
[0.10.1](v0.10.0...v0.10.1)
- 2024-05-07

### Added
- Display the transaction fee in NEAR and approximate $ after
transaction is executed
([#333](#333))
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/MarcoIeni/release-plz/).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display the transaction fee in NEAR and approximate $ after transaction is executed
2 participants