Add flat state specs to resharding NEP #570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wacban
approved these changes
Oct 29, 2024
neps/nep-0568.md
Outdated
Comment on lines
102
to
104
| 4) Children shards must apply the delta changes from the first block of the new | ||
| shard layout until the tip of the canonical chain. This operation is done in | ||
| another background task to avoid slowdowns while processing blocks. |
There was a problem hiding this comment.
It should be until the final block, not the tip.
neps/nep-0568.md
Outdated
Comment on lines
87
to
90
| For the reason stated above, the chosen strategy is to reshard Flat State in a | ||
| long-running background task. The new shards' states must converge with their | ||
| Mem Tries representation in a reasonable amount of time, indicatively by the | ||
| first half of the new epoch. |
There was a problem hiding this comment.
Why the first half of the new epoch? It's just for my information, no need to add it here. I don't think it's too important so maybe skip this part (the "indicatively by the first half of the new epoch").
There was a problem hiding this comment.
Removed!
It was badly worded; the flat state must converge with memtrie, at some point in time.
The time consideration was to have flat storage ready soon enough so that state parts for the new shards can be distributed before the next epoch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filling the specification section about flat state.