feat: add documentation on block processing #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://nomicon-pr-221.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c357dde31hsegue5thpg. |
bowenwang1996
commented
Jun 16, 2021
| - Chunk headers root computed from chunk headers does not match `chunk_headers_root` in the header. | ||
| - Transactions root computed from chunk headers does not match `chunk_tx_root` in the header. | ||
| - For some index `i`, `chunk_mask[i]` does not match whether a new chunk from shard `i` is included in the block. | ||
| - Its vrf output is invalid |
There was a problem hiding this comment.
Created #222 to track this
bowenwang1996
removed
the
WG-protocol
|
@bowenwang1996 Should this be merged eventually? Can you reassign the reviewer? |
frol
added
S-draft/needs-author-revision
bowenwang1996
commented
Feb 24, 2023
There was a problem hiding this comment.
I think it is still relevant. @mm-near could you review (or find someone else to review) this PR? Thanks!
ori-near
added
S-review/needs-wg-to-assign-sme
|
Hey @bowenwang1996 do you still want to proceed with this feat ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.