New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolving issue with Course Completion in Moodle 4.3 (#200) #201

Merged

NicoAlexH merged 3 commits into ndunand:master from opitz:CTP-2871

Jan 4, 2024

opitz commented Dec 5, 2023 •

edited

Loading

I have mended the code as follows:

replaced deprecated function print_error()
added suffix to completion rules for Moodle 4.3+
removed moodle_exception when $db_groups < 1 which would trigger the issue in Issue with Course Completion in Moodle 4.3 #200.

The last issue was caused by replacing print_error() - now deprecated - with throw new moodle_exception.

Matthias Opitz added 3 commits

November 23, 2023 17:32


          replaced deprecated function print_error()

217c542


          added suffix to completion rules

cc71083


          removed moodle_exception when $db_groups < 1

449277e

ndunand mentioned this pull request

Issue with Course Completion in Moodle 4.3 #200

Closed

NicoAlexH merged commit c1b5943 into ndunand:master

0 of 6 checks passed

Owner

ndunand commented Jan 4, 2024

thanks @opitz this has been checked and merged by @NicoAlexH

NicoAlexH mentioned this pull request

Moodle 4.x compatibility #192

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet