Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Max Enrollments Number #154

Merged
merged 2 commits into from
Jul 16, 2021
Merged

Max Enrollments Number #154

merged 2 commits into from
Jul 16, 2021

Conversation

sameer-ah
Copy link
Contributor

Fix: #142
-If 'Allow enrollment to multiple groups' is selected, there is an extra field to provide max enrollments number. Use default value 0 if there is no limit.

Fix: ndunand#142
-If 'Allow enrollment to multiple groups' is selected, there is an extra field to provide max enrollments number. Use default value 0 if there is no limit.
Copy link
Owner

@ndunand ndunand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sharing your work on this!

Just 2 small comments that I'd ask you to consider.

view.php Outdated Show resolved Hide resolved
view.php Outdated Show resolved Hide resolved
-Removed optional_param maxenrollments, instead $choicegroup->maxenrollments is used in the code.
@sameer-ah
Copy link
Contributor Author

Thanks for the review feedback. I have made suggested changes.

@ndunand ndunand merged commit 161d7df into ndunand:master Jul 16, 2021
@ndunand
Copy link
Owner

ndunand commented Jul 16, 2021

Thanks @sameer-ah for providing this feature! This will be released asap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request
2 participants