Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override Docker image command/args at runtime #13

Merged
merged 2 commits into from
Apr 21, 2023

Conversation

bodom0015
Copy link
Member

@bodom0015 bodom0015 commented Apr 21, 2023

Problem

Our API lets us specify command for an appspec, but this command does not seem to be used when running the container

Overriding the userapp.services.command lets us do this, but it does not automatically use the command from the appspec

In addition, args are completely ignored in the spec

Approach

  • Pass args into create_deployment
  • Use app_spec command if stack_service does not define one when creating the userapp

How to Test

  1. Checkout and run this branch locally
  2. Import a new AppSpec the overrides command, for an example see Create heapoverflow.json cheese-hub/catalog#15
  3. Create a new UserApp from this AppSpec (click + on All Apps page or use Swagger UI)
  4. Launch the UserApp and wait for it to finish starting up
    • You should see the app turn green in the UI
  5. Check kubectl get pods -n <namespace> and make sure container isn't Restarting over and over again

@bodom0015 bodom0015 changed the title [WIP] Override userapp command at runtime [WIP] Override Docker image command/args at runtime Apr 21, 2023
@bodom0015 bodom0015 changed the title [WIP] Override Docker image command/args at runtime Override Docker image command/args at runtime Apr 21, 2023
@bodom0015 bodom0015 merged commit e0c5384 into develop Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant