-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update demo and manual to use Stack GHC #460
Conversation
@@ -1,3 +1,8 @@ | |||
#!/bin/sh | |||
mkdir -p _shake | |||
ghc --make Build.hs -rtsopts -with-rtsopts=-I0 -outputdir=_shake -o _shake/build && _shake/build "$@" | |||
command -v stack >/dev/null 2>&1 | |||
if [ $? -eq 0 ]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tend to use if type stack > /dev/null 2>&1; then
as the guard here. Any reason to prefer your formulation or mine? (I'm not a big shell scripter, so defer to your knowledge here!)
Thanks! Although I slightly wonder if the guidance should be run to |
Since the docs recommend installing Shake with stack, a raw command to build.sh will likely fail due to missing libraries if a user tries to re-run the Shake demo after the initial `stack exec -- shake --demo` cmd.
That's a good point; keeping the Regarding |
Ah, interesting about ShellCheck - I haven't run it on that particular script for a while. Looks good, but on Windows it doesn't work - commercialhaskell/stack#2225 - I think this is a Stack bug so we'll see what they say before going forward. If it looks like it will be difficult to solve on their side we can have different Windows/Linux instructions, but I'd rather avoid that if we can. |
Stack have now fixed so |
Since the docs recommend installing Shake with stack, a raw command to
ghc will likely fail due to missing libraries if a user tries to re-run
the Shake demo after the initial
stack exec -- shake --demo
cmd.