Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generalize zip on empty lists hint #1565

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

generalize zip on empty lists hint #1565

wants to merge 4 commits into from

Conversation

jvoigtlaender
Copy link
Contributor

Will the notEq x [] in the side condition work as intended, or is extra "escaping" of the list brackets necessary as in lhs and rhs?

@googleson78
Copy link
Contributor

What's notEq?

@jvoigtlaender
Copy link
Contributor Author

The hlint-internal side condition combinator that is already used at various other places in the same file.

@ndmitchell
Copy link
Owner

The notEq looks fine. However, you have also used isNonEmpty. As far as I can tell, that hasn't been in hlint for many years. Yes, there was a use of it. But no, it didn't do anything, so I've deleted it. Can you remove the isNonEmpty uses.

@jvoigtlaender
Copy link
Contributor Author

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jvoigtlaender @googleson78 @ndmitchell