-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
listFilesRecursive loops on symlink loops #27
Comments
Yep, that is almost inevitable. Any recommended suggestions? Documentation seems like a minimal first step. |
I added a note to the docs. |
I'd suggest that it doesn't follow symlinks. It seems weird to me that it could return the filepaths parent (if it would return). |
That seems a plausible option, using https://hackage.haskell.org/package/directory-1.3.0.1/docs/src/System-Directory.html#pathIsSymbolicLink. Would you list files that are symbolic links? Or just not follow directories that were? |
I'd just not follow directories. This will avoid the most severe class of bugs. I can imagine that at least someone already did the following:
|
If you have symlinks to the root or similar, then you probably get away with it because The behaviour of not following inside directories which are symlinks seems reasonable to me. |
No description provided.
The text was updated successfully, but these errors were encountered: