Skip to content

Commit

Permalink
seiralise NanoCPUs as string
Browse files Browse the repository at this point in the history
Signed-off-by: Nicolas De Loof <[email protected]>
  • Loading branch information
ndeloof committed Oct 11, 2024
1 parent 7218685 commit 9184327
Show file tree
Hide file tree
Showing 2 changed files with 56 additions and 25 deletions.
56 changes: 56 additions & 0 deletions types/cpus.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,56 @@
/*
Copyright 2020 The Compose Specification Authors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/

package types

import (
"fmt"
"strconv"
)

type NanoCPUs float32

// MarshalYAML makes UnitBytes implement yaml.Marshaller
func (n *NanoCPUs) MarshalYAML() (interface{}, error) {
return fmt.Sprintf("%q", n), nil

Check failure on line 28 in types/cpus.go

View workflow job for this annotation

GitHub Actions / test (1.21, ubuntu-latest)

printf: fmt.Sprintf format %q has arg n of wrong type *github.com/compose-spec/compose-go/v2/types.NanoCPUs (govet)

Check failure on line 28 in types/cpus.go

View workflow job for this annotation

GitHub Actions / test (1.21, macos-latest)

printf: fmt.Sprintf format %q has arg n of wrong type *github.com/compose-spec/compose-go/v2/types.NanoCPUs (govet)
}

// MarshalJSON makes UnitBytes implement json.Marshaler
func (n *NanoCPUs) MarshalJSON() ([]byte, error) {
return []byte(fmt.Sprintf("%q", n)), nil

Check failure on line 33 in types/cpus.go

View workflow job for this annotation

GitHub Actions / test (1.21, ubuntu-latest)

printf: fmt.Sprintf format %q has arg n of wrong type *github.com/compose-spec/compose-go/v2/types.NanoCPUs (govet)

Check failure on line 33 in types/cpus.go

View workflow job for this annotation

GitHub Actions / test (1.21, macos-latest)

printf: fmt.Sprintf format %q has arg n of wrong type *github.com/compose-spec/compose-go/v2/types.NanoCPUs (govet)
}

func (n *NanoCPUs) DecodeMapstructure(a any) error {
switch v := a.(type) {
case string:
f, err := strconv.ParseFloat(v, 64)
if err != nil {
return err
}
*n = NanoCPUs(f)
case float32:
*n = NanoCPUs(v)
case float64:
*n = NanoCPUs(v)
default:
return fmt.Errorf("unexpected value type %T for cpus", v)
}
return nil
}

func (n *NanoCPUs) Value() float32 {
return float32(*n)
}
25 changes: 0 additions & 25 deletions types/types.go
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ import (
"encoding/json"
"fmt"
"sort"
"strconv"
"strings"

"github.com/docker/go-connections/nat"
Expand Down Expand Up @@ -391,30 +390,6 @@ type Resource struct {
Extensions Extensions `yaml:"#extensions,inline,omitempty" json:"-"`
}

type NanoCPUs float32

func (n *NanoCPUs) DecodeMapstructure(a any) error {
switch v := a.(type) {
case string:
f, err := strconv.ParseFloat(v, 64)
if err != nil {
return err
}
*n = NanoCPUs(f)
case float32:
*n = NanoCPUs(v)
case float64:
*n = NanoCPUs(v)
default:
return fmt.Errorf("unexpected value type %T for cpus", v)
}
return nil
}

func (n *NanoCPUs) Value() float32 {
return float32(*n)
}

// GenericResource represents a "user defined" resource which can
// only be an integer (e.g: SSD=3) for a service
type GenericResource struct {
Expand Down

0 comments on commit 9184327

Please sign in to comment.